Skip to content
Permalink
Branch: master
Commits on Jan 4, 2013
  1. Fixes potential NPE if no previous build exists

    ciaranj committed Jan 4, 2013
    Signed-off-by: ciaranj <ciaran.jessup@thisisnumero.com>
  2. [FIXES JENKINS-14321] - Do not re-use last build's environment for re…

    ciaranj authored and ciaranj committed Oct 3, 2012
    …mote polling
    
    Fixes, the original 'fix' in 3d9a73d it appears
    that a crucial check on the newly implemented argument wasn't actually implemented.
    
    I've changed the condition to test this rather than set 'b' to null if reuseLastBuildEnv
    is set to true as 'b' is de-referenced later in the getPollEnvironment method.
    
    Rather worryingly it appears that the existing code in getPollEnvironment tests at one
    point whether 'b' is null, but then later (outside this test) derefences it anyway, but
    this commit does not make that particular problem any worse.
    
    Signed-off-by: ciaranj <ciaranj@gmail.com>
You can’t perform that action at this time.