Skip to content

[JENKINS-63519] Git tool chooser chose the wrong implementation #3586

Closed

Description

@jenkins-infra-bot

I defined a git tool installer called "portable-git-2.28.0" to install Portable Git for Windows automatically onto Windows agents. I confirmed that the tool installer works as expected and is used when I clone with performance enhancements disabled.

When I enable performance enhancements, the repository size correctly hints that JGit should not be used. Unfortunately, instead of selecting the named git implementation that the job defines, it selects the implementation named "git".

In my case, that selection is not a serious issue, since the implementation named "git" is the default command line git installed on the agent.

I expected that it would select portable-git-2.28.0 as the git tool because that is the git tool that was defined for the job. I was assuming that if JGit is not selected, then the git tool defined in the job should be the preferred implementation.

Issue is visible in the /job/Tools/job/git-portable-for-windows/ job on my computer.


Originally reported by markewaite, imported from: Git tool chooser chose the wrong implementation
  • assignee: rishabhbudhouliya
  • status: Closed
  • priority: Minor
  • component(s): git-plugin
  • resolution: Fixed
  • resolved: 2020-09-12T15:00:21+00:00
  • votes: 2
  • watchers: 7
  • imported: 2025-12-02
Raw content of original issue

I defined a git tool installer called "portable-git-2.28.0" to install Portable Git for Windows automatically onto Windows agents. I confirmed that the tool installer works as expected and is used when I clone with performance enhancements disabled.

When I enable performance enhancements, the repository size correctly hints that JGit should not be used. Unfortunately, instead of selecting the named git implementation that the job defines, it selects the implementation named "git".

In my case, that selection is not a serious issue, since the implementation named "git" is the default command line git installed on the agent.

I expected that it would select portable-git-2.28.0 as the git tool because that is the git tool that was defined for the job. I was assuming that if JGit is not selected, then the git tool defined in the job should be the preferred implementation.

Issue is visible in the /job/Tools/job/git-portable-for-windows/ job on my computer.

environment
Jenkins 2.235.5<br/>
git plugin 4.4.0 with git tool chooser/performance improvements enabled
1 attachment

Activity

  1. jenkins-infra-bot commented on Aug 30, 2020

    @jenkins-infra-bot
    Author
    krachynski:
    • Original comment link
    • Raw content of original comment:

      Also worth noting that Node-/Agent-specific overrides to the default configuration get bypassed as well with performance enhancements enabled.

    Also worth noting that Node-/Agent-specific overrides to the default configuration get bypassed as well with performance enhancements enabled.

  2. jenkins-infra-bot commented on Sep 5, 2020

    @jenkins-infra-bot
    Author
    markewaite:
    • Original comment link
    • Raw content of original comment:

      A fix is in progress in PR-949. We'd love to have additional testing to confirm that the fix handles all the cases where issues are being encountered. I've uploaded a pre-release build as git-4.4.2-rc4027.193b7e5f6521.hpi . If your installation allows it, could you confirm that it resolves the issue you're seeing? If you encounter any problems with that pre-release build, please report them in PR-949.

    A fix is in progress in PR-949. We'd love to have additional testing to confirm that the fix handles all the cases where issues are being encountered. I've uploaded a pre-release build as git-4.4.2-rc4027.193b7e5f6521.hpi . If your installation allows it, could you confirm that it resolves the issue you're seeing? If you encounter any problems with that pre-release build, please report them in PR-949.

  3. jenkins-infra-bot commented on Sep 12, 2020

    @jenkins-infra-bot
    Author
    markewaite:

    Fix released in git plugin 4.4.2 Thanks rishabhbudhouliya!

  4. jenkins-infra-bot commented on Dec 2, 2025

    @jenkins-infra-bot
    Author

    [Original is_duplicated_by from Jira: JENKINS-63582]

  5. jenkins-infra-bot commented on Dec 2, 2025

    @jenkins-infra-bot
    Author

    [Original is_duplicated_by from Jira: JENKINS-63600]

  6. jenkins-infra-bot commented on Dec 2, 2025

    @jenkins-infra-bot
    Author

    [Original is_duplicated_by from Jira: JENKINS-63535]

  7. jenkins-infra-bot commented on Dec 2, 2025

    @jenkins-infra-bot
    Author

    [Original is_duplicated_by from Jira: JENKINS-63647]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions