Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-22009 Git Polling Keeps Detecting Changes When Variables in refspec #245

Merged
merged 1 commit into from Aug 8, 2014

Conversation

Projects
None yet
5 participants
@jakobk
Copy link

jakobk commented Jul 25, 2014

setup correct environment for polling + test case

Jakob Korherr
JENKINS-22009 Git Polling Keeps Detecting Changes When Variables in r…
…efspec (setup correct environment for polling + test case)
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Jul 25, 2014

plugins » git-plugin #418 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Jul 25, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Aug 2, 2014

This comment suggests that the bug is a regression in the plugin. Can you confirm that, and if so do you know (e.g., via git bisect) when that regressed?

@MarkEWaite

This comment has been minimized.

Copy link

MarkEWaite commented Aug 2, 2014

I think that the comment referencing a regression is from the git plugin prior to 2.0. Prior to 2.0, "fast remote polling" was disabled by default. The 2.0 release switched the default from "fast remote polling" disabled to "fast remote polling" enabled. The switch was a good one, since it improves performance. Unfortunately, the "fast remote polling" implementation can't do all the things which the "use workspace for polling" can.

@MarkEWaite

This comment has been minimized.

Copy link

MarkEWaite commented Aug 2, 2014

I attempted to cherry pick this change onto the 2.2.x branch. It fails to compile on that branch. It seems to depend on AbstractBuild having a getAllActions method.

Were you intending that this change would only be available with Jenkins versions after 1.568? That would mean there will not be a long term support release for use with your changes for at least 3 months, and possibly 6 months.

@jakobk

This comment has been minimized.

Copy link
Author

jakobk commented Aug 7, 2014

Sorry for the late response. Of course, I would like to include the change in the 2.2.x branch.
I created another pull request for the 2.2.x branch, fixing the API problems, see #250

MarkEWaite added a commit that referenced this pull request Aug 8, 2014

Merge pull request #245 from jakobk/jenkins_22009
JENKINS-22009 Git Polling Keeps Detecting Changes When Variables in refspec

@MarkEWaite MarkEWaite merged commit 03995f2 into jenkinsci:master Aug 8, 2014

@jakobk

This comment has been minimized.

Copy link
Author

jakobk commented Aug 8, 2014

Thanks for merging! I just updated the JIRA issue to Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.