Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-24467] fix and new test case #253
It shouldn't break any use case from 2.2.4 or before as the code that's changing was there yet. Nor does it break the functionality needed to resolve JENKINS-22009 which is what the original code was put in to do. I fear the original fix for JENKINS-22009 was too broad as it only needed ParameterActions to resolve the issue so this is just refining that fix.
Is there a use case you're worried about? I'm happy to change the PR if it will help get it accepted.
While evaluating this submission today (and last week), I saw an unexpected result which I am still investigating. My Debian Wheezy machines are running git version 188.8.131.52. That is the standard version for Debian Wheezy. On both Wheezy machines, the test fails before it ever reaches the assertion. It seems to fail because the git command is not able to find the git-upload-pack command.
I believe the difference is likely in the command line git program itself. I suspect that 184.108.40.206 required an external program "git-upload-pack" while later versions of git embedded the functions of that external program into the git executable, or changed the way they found that external executable. I intend to alter the test so that it will run on git 220.127.116.11, then merge the pull request into both the master branch and the 2.2.x branch.
Thanks for the pull request and for the time and energy you spent analyzing the root of the problem.