Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-24786] Environment variables are not expanded in git publisher #283

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dfigus
Copy link

dfigus commented Dec 22, 2014

Fix: Git publisher fails if remote repository configuration contains
environment variables

[JENKINS-24786] Environment variables are not expanded in git publisher
Fix: Git publisher fails if remote repository configuration contains
environment variables
@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Dec 22, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@MarkEWaite

This comment has been minimized.

Could you remove this trailing whitespace change?

[JENKINS-24786] Environment variables are not expanded in git publisher
Fix: Git publisher fails if remote repository configuration contains
environment variables

Fixed trailing whitespace in GitPublisherTest
@dfigus

This comment has been minimized.

Copy link
Author

dfigus commented Dec 22, 2014

Thanks for your fast feedback, trailing whitespace removed :-)

@MarkEWaite

This comment has been minimized.

Copy link

MarkEWaite commented Dec 23, 2014

Rebased into the master branch. It passed automated tests and my exploratory tests.

@MarkEWaite MarkEWaite closed this Dec 23, 2014

@tmertens

This comment has been minimized.

Copy link

tmertens commented on f841caf Jan 2, 2015

@MarkEWaite Any chance we can get a new release soon with this patch included? I'm trying to set up parameterized builds for auto-deploy to heroku and this is a blocker on the publishing side.

Keep up the great work!

This comment has been minimized.

Copy link

MarkEWaite replied Jan 2, 2015

A version of the plugin containing this change will likely release in a week or less.

Have you confirmed (with a pre-release build) that the change meets your needs? If not, would you be willing to test drive a pre-release if one were available within the next few days?

This comment has been minimized.

Copy link

tmertens replied Jan 2, 2015

I have not tried building the plugin myself, no. I just recently installed jenkins on AWS and am trying it out for auto-deploy. I tried updating from 2.2.10 to 2.3.2 to see if it resolved the issue. It didn't, so I glanced at the code and saw this recent patch was committed after the 2.3.2 release and appears to resolve the issue. I'd be happy to give a pre-release version a try if one is made available.

This comment has been minimized.

Copy link

MarkEWaite replied Jan 8, 2015

The git-plugin 2.3.3 and later includes this change

This comment has been minimized.

Copy link

tmertens replied Jan 8, 2015

Thanks. I actually built it a couple days ago and installed it, just upgraded to the official release. This resolves the issue I was seeing but now I'm hitting the timeout identified here: https://issues.jenkins-ci.org/browse/JENKINS-23476

Gonna see if I can make a quick patch for it, if it's a lot of effort I might have to go with a different approach.

This comment has been minimized.

Copy link

MarkEWaite replied Jan 8, 2015

Timeout on clone can be adjusted in the job definition from the job configuration page. Timeout on checkout can likewise be adjusted there. Timeout on submodule update is not implemented.

This comment has been minimized.

Copy link

tmertens replied Jan 8, 2015

The timeout is actually occurring on push with the git publisher.

This comment has been minimized.

Copy link

MarkEWaite replied Jan 8, 2015

If you're seeing a timeout on push, that would usually indicate that the authentication information is not correct. Unless your Jenkins job is adding enormous content to the repository, the push should be a very fast operation.

This comment has been minimized.

Copy link

tmertens replied Jan 8, 2015

The timeout on push occurs because heroku builds all of the resources as part of the push, so for large web apps it can take up to 15 minutes. Looking at the implementation for the other git 'additional behaviours' it seems like it should be easy to implement a similar timeout override for the push command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.