Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-24728 Added UI Elements for shallow clone depth #368

Closed
wants to merge 1 commit into from

Conversation

nastharl
Copy link

This is based off some old code, and i saw final got added to a lot of parts of the clone option. Not sure if i need to rework this due to that or not.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@MarkEWaite
Copy link
Contributor

@nastharl would you be willing to review 2de79b8b552b7930adc34bf527743f8abd30860f ? I spent a day exploring various alternatives and simplifications and would like your insights if you can detect issues with the changes I made.

Specifically, I'd like your insights on the JGit incompatibility which seems to result from the simplified implementatoin. Previously, JGit would warn that shallow clones are not supported, and would perform a full depth clone. The current implementation on 2de79b8b552b7930adc34bf527743f8abd30860f causes JGit to throw an error that shallow clone is not supported. I suspect that is because I've placed the depth setting on the fetch operations, not just on the clone operations.

I also implemented an automated acceptance test.

@MarkEWaite
Copy link
Contributor

A rebased and modified form of this commit was merged to the master branch as d96318d

@MarkEWaite MarkEWaite closed this Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants