Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option for submodule updating #43

Closed
wants to merge 1 commit into from
Closed

option for submodule updating #43

wants to merge 1 commit into from

Conversation

@bnovc
Copy link

bnovc commented Sep 14, 2011

My repository can require special processing on the submodules before
they are updated. This is because Gerrit is used, so the submodules
may not always point to refs/heads/, which is the only place git looks
at by default. This should really be fixed in git, but as a workaround
we have created a script that checks ls-remotes and updates to the
appropriate location.

This shouldn't be used in normal circumstances, so I would consider
this somewhat of a hack; however, the option itself doesn't require any
obtrusive code in the git plugin.

My repository can require special processing on the submodules before
they are updated. This is because Gerrit is used, so the submodules
may not always point to refs/heads/, which is the only place git looks
at by default. This should really be fixed in git, but as a workaround
we have created a script that checks ls-remotes and updates to the
appropriate location.

This shouldn't be used in normal circumstances, so I would consider
this somewhat of a hack; however, the option itself doesn't require any
obtrusive code in the git plugin.
@zyv

This comment has been minimized.

Copy link

zyv commented Nov 10, 2011

Hi!

I have submitted my pull request #48 before I discovered this one which does almost the same thing, although I think mine is better because it is more explicit. You not only don't update submodules, but as far as I understand don't do init either.

So anyway, this kind of makes the point that this functionality is necessary and important, but which request to adopt is to the discretion of the developers. It doesn't matter to me so much as long as it works.

Z.

@zyv

This comment has been minimized.

Copy link

zyv commented Nov 10, 2011

Ok, since #48 has been merged this is now obsolete.

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 10, 2011

This was integrated with pull request 48, thank you for this great idea!

@ghost ghost closed this Nov 10, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.