Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-26100] Switch buildEnvVars and others to Run #492
referenced this pull request
May 1, 2017
Not your fault, just a sign that this plugin’s
buildPlugin(jenkinsVersions: [null, '2.32.3'])
Last time I enabled the plugin compat tests, it failed because the combination of tests and compilation took more than an hour to complete. The ci.jenkins.io jobs (correctly) limit themselves to not more than an hour elapsed time for the total job.
Plugin compat testing is enabled again, and we'll see if it performs better now.
With plugin compat enabled, it now does not timeout (maybe a false recollection on my part). It reports findbugs warnings on the 2.46.1 build which it does not report on other builds. Unfortunately, my first attempts to duplicate that result locally have failed. My findbugs is silent, even when I set
My second attempt shows how to duplicate the problem. I mistakenly used -DskipTests, forgetting that it excludes findbugs runs for speed. If I run with at least one test, or with
I suspect I won't have time to explore fixes until after the end of the working day today.
Short term, I've stopped failing on findbugs warning messages. See daf202d
The most common introduced FB error is due to @stephenc’s messing around with
@SuppressFBWarnings(value="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE", justification="TODO 1.653+ switch to Jenkins.getInstanceOrNull")
Yes this is obnoxious which is why I asked him to leave existing methods alone, and rely on deprecations if necessary, but he insisted…
I'm not sure that action binding will work with the git plugin's current pom. As far as I can tell, once
My solution was