Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate and unhelpful tests #537

Merged
merged 2 commits into from Oct 16, 2017

Conversation

Projects
None yet
1 participant
@MarkEWaite
Copy link

commented Oct 7, 2017

Remove tests which do not add significant value, especially if they slow execution.

Parameter combining is a fundamental Jenkins core behavior, not something that needs specific testing in the git plugin.

MarkEWaite added some commits Oct 7, 2017

Remove RevisionParameterActionTest duplicate tests
Parameter combining is a fundamental Jenkins core behavior, not
something that needs specific testing in the git plugin.

Retains the one test in the class which used git operations.

@MarkEWaite MarkEWaite force-pushed the MarkEWaite:remove-duplicate-tests branch from a2caba3 to 5b55837 Oct 16, 2017

@MarkEWaite MarkEWaite merged commit f7065e9 into jenkinsci:master Oct 16, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@MarkEWaite MarkEWaite deleted the MarkEWaite:remove-duplicate-tests branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.