Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <tt> by <code> to fix javadoc failure on Java 11 #688

Merged
merged 6 commits into from Mar 11, 2019

Conversation

batmat
Copy link
Member

@batmat batmat commented Mar 9, 2019

New commit for #685 which I cannot push directly to.

cc @oleg-nenashev

Build failure when using JDK 11.0.2:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:jar (attach-javadocs) on project git: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:20: error: tag not supported in the generated HTML version: tt
[ERROR]  * e.g. If <tt>&#x2a;&#x2a;/master</tt> and <tt>&#x2a;&#x2a;/release-&#x2a;</tt> are configured as
[ERROR]            ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:20: error: tag not supported in the generated HTML version: tt
[ERROR]  * e.g. If <tt>&#x2a;&#x2a;/master</tt> and <tt>&#x2a;&#x2a;/release-&#x2a;</tt> are configured as
[ERROR]                                             ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:24: error: tag not supported in the generated HTML version: tt
[ERROR]  * This is useful, for example, when you have jobs building your <tt>master</tt> and various
[ERROR]                                                                  ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:25: error: tag not supported in the generated HTML version: tt
[ERROR]  * <tt>release</tt> branches and you want a second job which builds all new feature branches &mdash;
[ERROR]    ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:27: error: tag not supported in the generated HTML version: tt
[ERROR]  * <tt>master</tt> and the release branches again each time they change.
[ERROR]    ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/BuildChooser.java:190: warning: @return has already been specified
[ERROR]      * @return
[ERROR]        ^
[ERROR]
[ERROR] Command line was: /home/tiste/.tools/JDKs/jdk-11.0.2/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/tiste/dev/github/jenkinsci/git-plugin/target/apidocs' dir.

batmat and others added 6 commits March 8, 2019 14:56
And address associated errors with `RequireUpperBoundDeps` rule.

Also update parent pom to latest in the go.
```
Caused by: java.io.IOException: Pipeline: Step API v2.19 failed to load.
 - You must update Jenkins from v2.107.3 to v2.121.1 or later to run this plugin.
        at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:655)
```
Build failure when using JDK 11.0.2:

```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:jar (attach-javadocs) on project git: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:20: error: tag not supported in the generated HTML version: tt
[ERROR]  * e.g. If <tt>&#x2a;&#x2a;/master</tt> and <tt>&#x2a;&#x2a;/release-&#x2a;</tt> are configured as
[ERROR]            ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:20: error: tag not supported in the generated HTML version: tt
[ERROR]  * e.g. If <tt>&#x2a;&#x2a;/master</tt> and <tt>&#x2a;&#x2a;/release-&#x2a;</tt> are configured as
[ERROR]                                             ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:24: error: tag not supported in the generated HTML version: tt
[ERROR]  * This is useful, for example, when you have jobs building your <tt>master</tt> and various
[ERROR]                                                                  ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:25: error: tag not supported in the generated HTML version: tt
[ERROR]  * <tt>release</tt> branches and you want a second job which builds all new feature branches &mdash;
[ERROR]    ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/InverseBuildChooser.java:27: error: tag not supported in the generated HTML version: tt
[ERROR]  * <tt>master</tt> and the release branches again each time they change.
[ERROR]    ^
[ERROR] /home/tiste/dev/github/jenkinsci/git-plugin/src/main/java/hudson/plugins/git/util/BuildChooser.java:190: warning: @return has already been specified
[ERROR]      * @return
[ERROR]        ^
[ERROR]
[ERROR] Command line was: /home/tiste/.tools/JDKs/jdk-11.0.2/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/tiste/dev/github/jenkinsci/git-plugin/target/apidocs' dir.
```
@batmat batmat changed the title Remove obsolete tt Replace <tt> by <code> to fix javadoc failure on Java 11 Mar 9, 2019
@MarkEWaite MarkEWaite merged commit 3c8f1d7 into jenkinsci:master Mar 11, 2019
@batmat batmat deleted the remove-obsolete-tt branch March 11, 2019 14:39
@MarkEWaite MarkEWaite added the skip-changelog Exclude from the changelog label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Exclude from the changelog
Projects
None yet
3 participants