Skip to content
Permalink
Browse files

[JENKINS-43507] Found some minor bugs in the form validation action m…

…ethod names
  • Loading branch information...
stephenc committed Jun 23, 2017
1 parent e9df86e commit 8c5447bd5014844dd27943a7b76fd8bc24a7aeb2
Showing with 15 additions and 2 deletions.
  1. +15 −2 src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
@@ -1346,6 +1346,17 @@ public String getDisplayName() {
return Messages.GitHubSCMSource_DisplayName();
}

public ListBoxModel doFillCredentialsIdItems(@CheckForNull @AncestorInPath Item context,
@QueryParameter String apiUri) {
return Connector.listScanCredentials(context, apiUri);
}

public FormValidation doCheckCredentialsId(@CheckForNull @AncestorInPath Item context,
@QueryParameter String apiUri,
@QueryParameter String value) {
return Connector.checkScanCredentials(context, apiUri, value);
}

@Restricted(NoExternalUse.class)
public FormValidation doCheckIncludes(@QueryParameter String value) {
if (value.isEmpty()) {
@@ -1358,7 +1369,7 @@ public FormValidation doCheckIncludes(@QueryParameter String value) {
public FormValidation doCheckScanCredentialsId(@CheckForNull @AncestorInPath Item context,
@QueryParameter String apiUri,
@QueryParameter String scanCredentialsId) {
return Connector.checkScanCredentials(context, apiUri, scanCredentialsId);
return doCheckCredentialsId(context, apiUri, scanCredentialsId);
}

@Restricted(NoExternalUse.class)
@@ -1419,12 +1430,14 @@ public boolean isApiUriSelectable() {
return !GitHubConfiguration.get().getEndpoints().isEmpty();
}

@Restricted(NoExternalUse.class)
public ListBoxModel doFillCheckoutCredentialsIdItems(@CheckForNull @AncestorInPath Item context, @QueryParameter String apiUri) {
return Connector.listCheckoutCredentials(context, apiUri);
}

@Restricted(NoExternalUse.class)
public ListBoxModel doFillScanCredentialsIdItems(@CheckForNull @AncestorInPath Item context, @QueryParameter String apiUri) {
return Connector.listScanCredentials(context, apiUri);
return doFillCredentialsIdItems(context, apiUri);
}

public ListBoxModel doFillRepositoryItems(@CheckForNull @AncestorInPath Item context, @QueryParameter String apiUri,

0 comments on commit 8c5447b

Please sign in to comment.
You can’t perform that action at this time.