From d5db67e060293ddd351d22df07185cd009d547af Mon Sep 17 00:00:00 2001 From: Stephen Connolly Date: Thu, 4 May 2017 09:38:53 +0100 Subject: [PATCH] [JENKINS-43507] Documenting SCMNavigatorTrait and SCMNavigatorTraitDescriptor --- .../plugins/github_branch_source/BranchDiscoveryTrait.java | 2 +- .../github_branch_source/ForkPullRequestDiscoveryTrait.java | 2 +- .../OriginPullRequestDiscoveryTrait.java | 2 +- .../plugins/github_branch_source/SSHCheckoutTrait.java | 5 +++-- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java index 172f48e67..42e5b7f92 100644 --- a/src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java +++ b/src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java @@ -111,7 +111,7 @@ public String getDisplayName() { } @Override - public boolean isApplicableToContext(Class contextClass) { + public boolean isApplicableToContext(@NonNull Class contextClass) { return GitHubSCMSourceRequest.class.isAssignableFrom(contextClass); } diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java index 77c9ccbef..2b67051e7 100644 --- a/src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java +++ b/src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java @@ -86,7 +86,7 @@ public String getDisplayName() { } @Override - public boolean isApplicableToContext(Class contextClass) { + public boolean isApplicableToContext(@NonNull Class contextClass) { return GitHubSCMSourceRequest.class.isAssignableFrom(contextClass); } diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java index b44490a75..674f2b656 100644 --- a/src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java +++ b/src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java @@ -75,7 +75,7 @@ public String getDisplayName() { } @Override - public boolean isApplicableToContext(Class contextClass) { + public boolean isApplicableToContext(@NonNull Class contextClass) { return GitHubSCMSourceRequest.class.isAssignableFrom(contextClass); } diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java index 5921552ce..a64042c48 100644 --- a/src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java +++ b/src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java @@ -5,6 +5,7 @@ import com.cloudbees.plugins.credentials.common.StandardListBoxModel; import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials; import edu.umd.cs.findbugs.annotations.CheckForNull; +import edu.umd.cs.findbugs.annotations.NonNull; import hudson.Extension; import hudson.model.Item; import hudson.model.Queue; @@ -53,12 +54,12 @@ public String getDisplayName() { } @Override - public boolean isApplicableToContext(Class contextClass) { + public boolean isApplicableToContext(@NonNull Class contextClass) { return GitHubSCMSourceRequest.class.isAssignableFrom(contextClass); } @Override - public boolean isApplicableToSCM(SCMDescriptor scm) { + public boolean isApplicableToSCM(@NonNull SCMDescriptor scm) { return scm instanceof GitSCM.DescriptorImpl; }