Skip to content
Permalink
Branch: master
Commits on Jan 18, 2019
  1. Need to loop twice

    stephenc committed Jan 18, 2019
    In the event that a directory contains both `JENKINSFILE` and `Jenkinsfile`. If we are looking for `Jenkinsfile` then without looping twice we would see `JENKINSFILE` first (because alpha sort puts uppercase before lowercase) and return the alert of mismatch... what we want to do is exhaustively search for the correct name and only in the event of no exact match should we check for alternative case variants
Commits on Nov 16, 2018
  1. [FIXED JENKINS-52397] Hit-and-run fix attempt

    stephenc committed Nov 16, 2018
Commits on Sep 28, 2018
  1. Experiment: Always force remote validation

    stephenc committed Sep 28, 2018
    - Conditional GET requests only consume API rate counters if they result
      in a non-304 response, and this may be the only way to bypass race
      conditions inherent with turning on caching (assuming that GitHub
      servers actually give us the correct response... but that's why
      we have `eventDelaySeconds`... so we should only be checking *after*
      GitHub has been given the 5 seconds to get their front-end caches
      cleared.)
Commits on Sep 26, 2018
  1. Use a consistent salt not a one that is random with every restart

    stephenc committed Sep 26, 2018
Commits on Sep 21, 2018
  1. Findbugs!

    stephenc committed Sep 21, 2018
  2. Turn back on the on-disk cache.

    stephenc committed Sep 21, 2018
    - For reasons that are lost in the mists of time, the on-disk cache
      proved problematic before. I suspect the issue was that the cache
      needs to be sharded by credentials as well as api url. We cannot use
      the same cache as the GitHub plugin because they use a different
      credentials type.
    - Defaulting to 20MB and on. Can be disabled by setting the system
      property to `0` or using the Groovy console:
      `org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.cacheSize`
  3. Do not release connection objects immediately

    stephenc committed Sep 21, 2018
    - The connection object has some internal cached state, allow for retention of that state between scans to avoid repeatedly looking up things like user details, etc.
  4. Adding some very basic API usage optimizations

    stephenc committed Sep 21, 2018
    - No need to keep revalidating the API URL when it has been known valid
      recently (within the last 5 minutes)
    - `GitHub.isCredentialsValid()` wastes an API call replicating what
      `GitHub.getMyself()` does, only without storing the user object so
      that subsequent calls of `GitHub.getMyself()` result in an additional
      API call. Rewrote these calls to use `GitHub.getMyself()` so that
      we should thus only need to query `https://api.github.com/user`
      once per connection object.
    - When checking the branches of a repository for a match, always try
      the default branch first as that has the highest chance of containing
      any marker files and can therefore short-circuit at-least-one checks
Commits on Aug 7, 2018
  1. Merge pull request #179 from steven-foster/JENKINS-38706

    stephenc committed Aug 7, 2018
    JENKINS-50323 Public constructors for PullRequestSCMHead and PullRequestSCMRevision
Commits on May 10, 2018
  1. Merge pull request #175 from steven-foster/JENKINS-47366

    stephenc committed May 10, 2018
    [JENKINS-47366] Avoid reporting premature build status
Commits on Apr 17, 2018
  1. Merge pull request #180 from jglick/export-JENKINS-50777

    stephenc committed Apr 17, 2018
    [JENKINS-50777] Exporting PullRequestSCMRevision.pullHash
Commits on Mar 9, 2018
  1. Merge pull request #178 from stephenc/more-logging

    stephenc committed Mar 9, 2018
    [FIXED JENKINS-49945] Fix regex and add some logging to help diagnose issues in resolve(thingName,listener)
Commits on Mar 8, 2018
  1. Add some logging to help diagnose issues in resolve(thingName,listener)

    stephenc committed Mar 8, 2018
    - Also fixes an issue with the regex for PR-n-HEAD and PR-n-MERGE
Commits on Dec 18, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Dec 18, 2017
  2. [maven-release-plugin] prepare release github-branch-source-2.3.2

    stephenc committed Dec 18, 2017
  3. Merge pull request #163 from stephenc/lightweight-changelog

    stephenc committed Dec 18, 2017
    [JENKINS-47585] Implement lightweight changelog
  4. Findbugs FTW

    stephenc committed Dec 18, 2017
  5. Merge branch 'master' into lightweight-changelog

    stephenc committed Dec 18, 2017
  6. Merge branch 'master' into lightweight-changelog

    stephenc committed Dec 18, 2017
  7. Merge pull request #170 from rsandell/JENKINS-48035

    stephenc committed Dec 18, 2017
    [JENKINS-48035] Add a GitHubRepositoryNameContributor that recognises…
  8. Merge pull request #162 from steven-foster/JENKINS-36574

    stephenc committed Dec 18, 2017
    [JENKINS-36574] Custom Github status context
  9. Merge pull request #159 from batmat/more-diagnostics-when-no-url-vali…

    stephenc committed Dec 18, 2017
    …dity
    
    Chain the cause exception and log in case of failure
Commits on Dec 13, 2017
  1. Pick up version of github api that supports Long ids

    stephenc committed Dec 13, 2017
Commits on Nov 16, 2017
  1. [JENKINS-36574] And example stub test

    stephenc committed Nov 16, 2017
Commits on Nov 9, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Nov 9, 2017
  2. Merge pull request #167 from stephenc/jenkins-47902

    stephenc committed Nov 9, 2017
    [FIXED JENKINS-47902] I think this is the fix
  3. [FIXED JENKINS-47902] I think this is the fix

    stephenc committed Nov 9, 2017
Commits on Nov 7, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Nov 7, 2017
  2. Merge pull request #158 from stephenc/jenkins-34395

    stephenc committed Nov 7, 2017
    [JENKINS-34395] Support for tag discovery
Commits on Nov 6, 2017
  1. Merge branch 'master' into jenkins-34395

    stephenc committed Nov 6, 2017
  2. Merge branch 'master' into jenkins-34395

    stephenc committed Nov 6, 2017
Commits on Nov 4, 2017
  1. [maven-release-plugin] prepare for next development iteration

    stephenc committed Nov 4, 2017
Older
You can’t perform that action at this time.