Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not building origin merge when webhook is received. #131

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
7 participants
@tecnobrat
Copy link

tecnobrat commented Mar 31, 2017

This looks like a simple typo, as its different (and the logic seems correct) here:

@kzantow

This comment has been minimized.

Copy link

kzantow commented Mar 31, 2017

This LGTM; need to get maintainers to approve it, though.

@rsandell

This comment has been minimized.

Copy link
Member

rsandell commented Mar 31, 2017

LGTM 👍

@stephenc stephenc merged commit 24c1589 into jenkinsci:master Mar 31, 2017

1 check passed

Jenkins This pull request looks good
Details
@tecnobrat

This comment has been minimized.

Copy link
Author

tecnobrat commented Mar 31, 2017

@stephenc is there any way we can get a new version built for this? Thanks!

@tecnobrat tecnobrat deleted the tecnobrat:patch-1 branch Mar 31, 2017

@stephenc

This comment has been minimized.

Copy link
Member

stephenc commented Mar 31, 2017

It's after 5:30pm on a Friday! Aint going to happen this side of the weekend 😜

@tecnobrat

This comment has been minimized.

Copy link
Author

tecnobrat commented Mar 31, 2017

But I opened this 12 hours ago! :trollface:

Didn't realize you were in Ireland ;) Only 10:30am over here.

@michaelneale

This comment has been minimized.

Copy link
Member

michaelneale commented Mar 31, 2017

OMG outstanding catch!

@tecnobrat the benefit of timezones is that at leaast you get it before your monday.

🍺

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Mar 31, 2017

FTR looks like this was broken since its introduction in #93, so not a regression as such.

@tecnobrat

This comment has been minimized.

Copy link
Author

tecnobrat commented Apr 5, 2017

@stephenc any chance we can get a release on this? :)

Its blocking our workflows :) Thanks!

@stephenc

This comment has been minimized.

Copy link
Member

stephenc commented Apr 5, 2017

2.0.5 on the way

@stephenc

This comment has been minimized.

Copy link
Member

stephenc commented Apr 5, 2017

Should be released now but thanks to https://issues.jenkins-ci.org/browse/INFRA-1135 I cannot update the wiki with the release notes

@autogun

This comment has been minimized.

Copy link

autogun commented Apr 6, 2017

Updated today and it seems like bunch of PRs were indexed with no Jenkinsfile in the code.
But index says "Jenkinsfile found"...

Checking pull request #1644
(not from a trusted source)
Job name: PR-1644
  ‘Jenkinsfile’ found
  Not mergeable, but will be built anyway
Met criteria

No changes detected: PR-1644 (still at xxxx)

Could be related?

@stephenc

This comment has been minimized.

Copy link
Member

stephenc commented Apr 6, 2017

@autogun if it is not from a trusted source then the Jenkinsfile will come from the target branch not the PR itself... Also the Jenkins JIRA is a better place to comment as attaching comments to a merged PR is typically just as effective as using

echo "Description of my issue" >> /dev/null

The only reason I saw this was because the tab was still open and I was closing it... once it had been closed your comment would have ended up in /dev/null. Please use the Jenkins JIRA in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.