[JENKINS-48035] Add a GitHubRepositoryNameContributor that recognises… #170
Conversation
… multi branch The existing name contributors could only find the repo name if a build of a branch had been made and added git build data to the job. Since branches are discovered and built after GitHubSCMSource.afterSaved is called there was no repo names recognised to add webhooks to. This only solves the case when a single multi branch project is created. Because when an org folder creates the multi branch jobs it does not call afterSaved on the children. So that needs to be fixed someplace else.
|
|
||
| import java.util.Collection; | ||
|
|
||
| @Extension |
pom.xml
Outdated
| @@ -68,6 +68,11 @@ | |||
| <artifactId>display-url-api</artifactId> | |||
| <version>0.2</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Oh I am not happy about this being escalated from test. Ping me tomorrow. We need to find a different way
There was a problem hiding this comment.
I first tried with SCMSource.SourceByItem.findSource(item) but the problem there was that it only found the source for actual branch jobs, so it doesn't work on afterSave because there are no branch jobs available at that time, so still no repository to discover.
There was a problem hiding this comment.
if (item instanceof SCMSourceOwner) {
...
}
|
@abayer well, I can't add a test that verifies the actual issue because of rate limits on GitHub etc. I'm trying to come up with something. |
|
|
||
| @Override | ||
| public void parseAssociatedNames(Item item, Collection<GitHubRepositoryName> result) { | ||
| if (item instanceof MultiBranchProject) { |
There was a problem hiding this comment.
instanceof SCMSourceOwner and you are only using that classes method anyway
|
@stephenc any thoughts on where to put in a call to |
Well that should be in branch-api |
|
|
||
| import java.util.Collection; | ||
|
|
||
| @Extension |
Should be addressed by jenkinsci/branch-api-plugin#120 |
| @Extension | ||
| public class GitHubSCMSourceRepositoryNameContributor extends GitHubRepositoryNameContributor { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
🐜 (From https://github.com/jenkinsci/scm-api-plugin/blob/master/CONTRIBUTING.md#javadoc):
- When a method is overriding a method from a super-class / interface, unless the semantics of the method have changed it is sufficient to document the intent of implementing the super-method's contract with:
/** * {@inheritDoc} */ @Override
… multi branch
The existing name contributors could only find the repo name if a build
of a branch had been made and added git build data to the job.
Since branches are discovered and built after GitHubSCMSource.afterSaved is called
there was no repo names recognised to add webhooks to.
This only solves the case when a single multi branch project is created.
Because when an org folder creates the multi branch jobs it does not call
afterSaved on the children. So that needs to be fixed someplace else.
@reviewbybees