Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JENKINS-33883 by allowing .*/cc.xml instead of only root one. #52

Merged
merged 1 commit into from May 15, 2016

Conversation

@ssbarnea
Copy link
Contributor

ssbarnea commented May 3, 2016

No description provided.

@samrocketman

This comment has been minimized.

Copy link
Member

samrocketman commented May 15, 2016

I will review this, test, and merge before the next release. It will be in 0.24.

@ssbarnea

This comment has been minimized.

Copy link
Contributor Author

ssbarnea commented May 15, 2016

Thanks. I am already using it in production since two weeks ago and didnt had any problems.

Still, you will observe that is quite inconvenient to use a cc.xml with github organization plugin because of the multiple cc.xml files. Also the published job names are the branch names, so you may not be able to distinguish between jobs. Still this is another issue that has nothing to do with the auhentication plugin.

@samrocketman

This comment has been minimized.

Copy link
Member

samrocketman commented May 15, 2016

No sure I fully comprehend because I don't use cruise control. However, if after testing it doesn't affect the functionality of the plugin in a negative way and it helps you out; then I see no reason not to include it.

@samrocketman samrocketman merged commit 87ff4fc into jenkinsci:master May 15, 2016
1 check passed
1 check passed
Jenkins This pull request looks good
Details
samrocketman added a commit that referenced this pull request May 15, 2016
@samrocketman

This comment has been minimized.

Copy link
Member

samrocketman commented May 26, 2016

Released 0.24. It should be available in about 8 hrs in the update center. Or download it at https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-oauth/0.24/github-oauth-0.24.hpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.