diff --git a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java index 7454bb75..7f0f5b6f 100644 --- a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java +++ b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java @@ -260,7 +260,8 @@ public boolean hasRepositoryPermission(GithubAuthenticationToken authenticationT if (permission.equals(Item.READ) || permission.equals(Item.CONFIGURE) || permission.equals(Item.DELETE) || - permission.equals(Item.EXTENDED_READ)) { + permission.equals(Item.EXTENDED_READ) || + permission.equals(Item.CANCEL)) { return true; } else { return false; diff --git a/src/main/webapp/help/auth/use-repository-permissions-help.html b/src/main/webapp/help/auth/use-repository-permissions-help.html index 7e5f615f..3ab87e2e 100644 --- a/src/main/webapp/help/auth/use-repository-permissions-help.html +++ b/src/main/webapp/help/auth/use-repository-permissions-help.html @@ -1,7 +1,7 @@
If checked will use github repository permissions to determine jenkins permissions for each project.
diff --git a/src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java b/src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java index 6a9baafd..0c5cf730 100644 --- a/src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java +++ b/src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java @@ -463,6 +463,7 @@ public void testCanReadConfigureDeleteAProjectWithAuthenticatedUserReadPermissio assertTrue(acl.hasPermission(authenticationToken, Item.CONFIGURE)); assertTrue(acl.hasPermission(authenticationToken, Item.DELETE)); assertTrue(acl.hasPermission(authenticationToken, Item.EXTENDED_READ)); + assertTrue(acl.hasPermission(authenticationToken, Item.CANCEL)); } @Test @@ -480,6 +481,7 @@ public void testCannotReadConfigureDeleteAProjectWithoutToAuthenticatedUserReadP assertFalse(acl.hasPermission(authenticationToken, Item.CONFIGURE)); assertFalse(acl.hasPermission(authenticationToken, Item.DELETE)); assertFalse(acl.hasPermission(authenticationToken, Item.EXTENDED_READ)); + assertFalse(acl.hasPermission(authenticationToken, Item.CANCEL)); } @Test