New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gitlabMergeRequestTargetProjectId variable #510

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
3 participants
@tomasbjerre
Copy link
Contributor

tomasbjerre commented Feb 20, 2017

The project ID is needed when using the GitLab rest API to get information about the merge request.

@tomasbjerre tomasbjerre force-pushed the tomasbjerre:master branch from 4541064 to c60abd4 Feb 20, 2017

@tomasbjerre

This comment has been minimized.

Copy link
Contributor Author

tomasbjerre commented Mar 3, 2017

@omehegan Tell me if there is anything unclear here.

I really need this in order to use https://github.com/jenkinsci/violation-comments-to-gitlab-plugin

@omehegan

This comment has been minimized.

Copy link
Member

omehegan commented Mar 8, 2017

@tomasbjerre thanks! This looks pretty straightforward. I normally merge small PRs like this in groups and do a release. I will try to do one in the next few days.

@drndos

This comment has been minimized.

Copy link

drndos commented Apr 10, 2017

You forgot to edit MergeRequestHookTriggerHandlerImpl
and add .withMergeRequestTargetProjectId(hook.getObjectAttributes().getTargetProjectId())
after .withMergeRequestIid(hook.getObjectAttributes().getIid())

@tomasbjerre tomasbjerre force-pushed the tomasbjerre:master branch from c60abd4 to 4c6684b Apr 10, 2017

@tomasbjerre

This comment has been minimized.

Copy link
Contributor Author

tomasbjerre commented Apr 10, 2017

Fixed

@tomasbjerre tomasbjerre force-pushed the tomasbjerre:master branch from 4c6684b to c74f336 Apr 24, 2017

@omehegan omehegan merged commit c92e972 into jenkinsci:master May 9, 2017

1 check passed

Jenkins This pull request looks good
Details
@omehegan

This comment has been minimized.

Copy link
Member

omehegan commented Jul 5, 2017

This was released today in version 1.4.6 of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment