Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gitlabMergeRequestTargetProjectId variable #510

Merged
merged 1 commit into from May 9, 2017
Merged

Adding gitlabMergeRequestTargetProjectId variable #510

merged 1 commit into from May 9, 2017

Conversation

tomasbjerre
Copy link
Contributor

The project ID is needed when using the GitLab rest API to get information about the merge request.

@tomasbjerre
Copy link
Contributor Author

@omehegan Tell me if there is anything unclear here.

I really need this in order to use https://github.com/jenkinsci/violation-comments-to-gitlab-plugin

@omehegan
Copy link
Member

omehegan commented Mar 8, 2017

@tomasbjerre thanks! This looks pretty straightforward. I normally merge small PRs like this in groups and do a release. I will try to do one in the next few days.

@drndos
Copy link

drndos commented Apr 10, 2017

You forgot to edit MergeRequestHookTriggerHandlerImpl
and add .withMergeRequestTargetProjectId(hook.getObjectAttributes().getTargetProjectId())
after .withMergeRequestIid(hook.getObjectAttributes().getIid())

@tomasbjerre
Copy link
Contributor Author

Fixed

@omehegan omehegan merged commit c92e972 into jenkinsci:master May 9, 2017
@omehegan
Copy link
Member

omehegan commented Jul 5, 2017

This was released today in version 1.4.6 of the plugin.

exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this pull request May 20, 2022
* Fix class mismatch (findbugs)

* findbugs fixes, contd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants