Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLA Requirement and Remove obsolete PR builder link #16

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Apr 2, 2018

This is a follow-up to the JENKINS-50216 discussion with @tcnghia in the email threads. According to this discussion, CLA is no longer required.

This PR needs to be integrated in order to unblock JEP-200 maintainers.

CC @reviewbybees @jglick

@jglick
jglick approved these changes Apr 5, 2018
@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Apr 12, 2018

@astroilov What are the next steps here? We cannot propose JEP-200 fixes until it is integrated into the master

@astroilov
Copy link
Contributor

astroilov commented Apr 16, 2018

It appears that I no longer have write access, meaning I cannot merge this PR (or the actual fix PR that you have sent). I will see if I can find another reviewer that does have write access among those who've worked on this plugin. If it was accidentally "owner-orphaned", we may need to contact one of the owners of the jenkinsci org.

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Apr 17, 2018

@astroilov It is easy to fix, because I am one of admins. We were doing permission cleanup this February: https://groups.google.com/forum/#!msg/jenkinsci-dev/ksKAsmsmVng/xHyym1fYAAAJ;context-place=forum/jenkinsci-dev, so likely you lost permissions during it (you were getting them from the Everyone group).

Restored your permissions, please let me know whom I should also add to this plugin or other plugins Google maintains

@daniel-beck
Copy link
Member

daniel-beck commented Apr 17, 2018

@oleg-nenashev Not quite. The permissions for this repo were granted via the oauth-credentials-developers team during a time we hadn't locked down what regular users could do, and some used that to make an absolute mess of per-repo teams. That was a separate cleanup. See the audit log.

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Apr 17, 2018

Now there is a single team with "Write" permission. Should be fine, right?

@astroilov astroilov merged commit 62126a6 into jenkinsci:master Apr 17, 2018
@astroilov
Copy link
Contributor

astroilov commented Apr 17, 2018

Ah, that does make things easier! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.