Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Google Play Console Internal test track. #8

Closed

Conversation

@sergebeauchampGoogle
Copy link

sergebeauchampGoogle commented Mar 20, 2018

The Google Play Console supports a new Internal test track, see:

https://support.google.com/googleplay/android-developer/answer/3131213

This is available through the API by targeting the 'internal' track.

@orrc

This comment has been minimized.

Copy link
Member

orrc commented Mar 20, 2018

Oh, nice, so it just works — I was going to try out just adding "internal" today to see whether it would work! :)

Thanks for the code, and the insight about the versionCodes being separate.

I will give this some testing, and make a release this week — I have a couple of other fixes I need to release as well.

@sergebeauchampGoogle

This comment has been minimized.

Copy link
Author

sergebeauchampGoogle commented Mar 20, 2018

Actually, I just checked, and the restriction to have a unique APK per track is not yet lifted for the internal track.

I'll add another pull request to update this accordingly.

@darthg8r

This comment has been minimized.

Copy link

darthg8r commented Apr 17, 2018

Is there an expected release date that includes this PR?

@maxhille

This comment has been minimized.

Copy link

maxhille commented Apr 17, 2018

Just FYI, uploading to 'alpha' will also upload the 'internal' track automatically it seems.

EDIT: redacted, does not seem to work

@tbsandee

This comment has been minimized.

Copy link

tbsandee commented Apr 17, 2018

@maxhille that's good to know, if it's true. It didn't at first, failing with a deployment error. Maybe Google started mapping alpha to internal by default.

@darthg8r

This comment has been minimized.

Copy link

darthg8r commented Apr 19, 2018

I guess I'll clone and build this myself... It'd be nice to get this released guys, it's been a month.

@maxhille

This comment has been minimized.

Copy link

maxhille commented Apr 20, 2018

@tbsandee Unfortunately, 'internal' does not seem to also update when uploading to alpha now. I think it 'worked'/happened once but not again. I am confused now.

@mseroczynski

This comment has been minimized.

Copy link

mseroczynski commented Apr 20, 2018

Anything is currently blocking this PR? It's functionality seems really useful.

@orrc

This comment has been minimized.

Copy link
Member

orrc commented Apr 26, 2018

In order to release, it would be good to know whether these changes actually work — you can help by giving feedback on the plugin build that includes these changes.

In particular, it would be good to know whether this logic which is supposedly different to the other tracks (or not, according to comment #3‽) works as expected — i.e. can you upload APKs to internal and then successfully upload newer APKs to alpha or beta with this plugin?

@dmarjanovic

This comment has been minimized.

Copy link

dmarjanovic commented May 7, 2018

I built plugin directly from this PR and all worked as expected with my single APK+deobfuscation file deployments.

can you upload APKs to internal and then successfully upload newer APKs to alpha or beta with this plugin?

Yes, I used parametrized job so with the same job I was able to publish APK to Internal test track, then with 2nd build to publish APK with incremented versionCode to Alpha track, then with 3rd build to publish newer APK to Beta track, 4rd build again to Internal test and so on. Debfuscation file was always getting uploaded successfully with each APK too so for me it worked perfectly with all tracks.
screen shot 2018-05-07 at 10 15 20 pm

@orrc is any more testing needed or you think there may be progress with this PR? Thank you.

👍

@mlazowik

This comment has been minimized.

Copy link

mlazowik commented May 30, 2018

@orrc pinging in case you missed the last comment :)

@cwiley982

This comment has been minimized.

Copy link

cwiley982 commented Jun 1, 2018

It seems like this PR is really close to getting released since @dmarjanovic tested it and found that it works. Is there anything we can do to help move it along to being merged? We plan on using it as soon as it's released so we'd love to have it soon!

@darthg8r

This comment has been minimized.

Copy link

darthg8r commented Jun 1, 2018

I gave up on waiting for the PR to be accepted. I ended up downloading the CI package and installing it and have been using it for a month.

@orrc

This comment has been minimized.

Copy link
Member

orrc commented Jun 3, 2018

Sorry for the delay. Thanks to Serge for the patch, @dmarjanovic for testing (again), and fewer thanks to those who tested but didn't give any feedback… ;)

This has been merged, and version 1.8 of the plugin has been released which includes uploading to the internal track.

@orrc orrc closed this Jun 3, 2018
@cmarcelk

This comment has been minimized.

Copy link

cmarcelk commented Jun 4, 2018

Thanks for the merge and release. We're using this starting today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.