Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-44834] Partial pipeline support #52

Open
wants to merge 10 commits into
base: master
from

Conversation

@alexbrjo
Copy link

alexbrjo commented Jun 28, 2017

JENKINS-44834 Adds a withGradle pipeline step to set up the Gradle environment and annotates the build output. Provides Gradle and JDK tool selection from pipeline.

TODO? add test for console annotation
TODO? add test for reloading annotator on Jenkins restart
*/

@Test
public void testStepDefaultTools() throws Exception {
String name = ToolInstallations.configureDefaultGradle(new TemporaryFolder()).getName();

This comment has been minimized.

Copy link
@wolfs

wolfs Jul 6, 2017

Member

I actually would prefer that the Gradle plugin itself would publish a test fixture so that other plugins can depend on it and the fixture itself is more adjusted to the needs of Gradle. Even the test-harness-tools state that this should be the strategy for the future:

New versions are unreleasable. Alternatives to consider:

  • allowing plugins to specify test-scoped dependencies on tool zips, with some utility to extract those in jenkins-test-harness, and an extension handler in maven-hpi-plugin allowing them to be added to the classpath
  • use docker-fixtures to connect to agents running well-defined versions of various tools

I will not reject merging this PR if this is the only problem. We should consider that in the future.

This comment has been minimized.

Copy link
@jglick

jglick Jul 6, 2017

Member

We talked about using docker-fixtures for tests in this PR, though it is more work to set up.

@jglick

This comment has been minimized.

Copy link
Member

jglick commented Jul 6, 2017

Note: not currently attempting to include the functionality of #34, or some other Gradle options that could plausibly be ported like useWorkspaceAsHome (though that should really be using workspace@tmp like Pipeline pwd tmp: true does).

@jglick
jglick approved these changes Jul 6, 2017
Copy link
Member

jglick left a comment

LGTM pending build fixes.

@alexbrjo alexbrjo changed the title [WIP][JENKINS-44834] Partial pipeline support [JENKINS-44834] Partial pipeline support Jul 17, 2017
alexbrjo added 10 commits Jun 21, 2017
* Block invocation and output is annotated
* added more logging for trouble shooting and debugging
* Gradle and jdk tool selection
* Also added TODO comments for dependency releases that are blockers
* Added symbol's back
Tests no longer depend on a local gradle installation
* manually tested by uninstalling gradle from local machine
* added unit test to confirm Jenkin's gradle installation is being used
* Added config.jelly for pipeline snippetizer
* Cleaned up variable name conventions
@alexbrjo alexbrjo force-pushed the alexbrjo:pipeline-compat branch from 32b788b to e7d659f Aug 8, 2017
@jglick jglick requested a review from abayer Aug 8, 2017
@notxcain

This comment has been minimized.

Copy link

notxcain commented Aug 28, 2017

Is there any ticket/issue referencing ability to use Gradle inside tools directive of declarative pipeline?

tools {
  gradle 'Gradle 3.2.1'
}
@alexbrjo

This comment has been minimized.

Copy link
Author

alexbrjo commented Aug 28, 2017

@notxcain afaict looks like its already supported

@notxcain

This comment has been minimized.

Copy link

notxcain commented Aug 28, 2017

@alexbrjo wow, I don't know how I missed that line :) thanks!

@alexbrjo

This comment has been minimized.

Copy link
Author

alexbrjo commented Oct 6, 2017

gradle-jpi-plugin #87 was just merged with the transitive dependency fix. Once it is released I will push a commit to fix the CI build.

edit: linked wrong PR

@oleg-nenashev

This comment has been minimized.

Copy link
Member

oleg-nenashev commented Dec 6, 2017

@alexbrjo #87 has been integrated, I think this is unblocked

@ghost

This comment has been minimized.

Copy link

ghost commented Feb 7, 2018

Any chance someone can pick this up and get it merged / published?

@wolfs

This comment has been minimized.

Copy link
Member

wolfs commented Jul 3, 2018

@alexbrjo What is the state of this PR? Should this be ready to integrate?

@wolfs

This comment has been minimized.

Copy link
Member

wolfs commented Aug 18, 2018

@alexbrjo @oleg-nenashev Are you going to pick up this PR?

@DJViking

This comment has been minimized.

Copy link

DJViking commented Jan 14, 2019

What is the holdup on getting this out?

@wolfs

This comment has been minimized.

Copy link
Member

wolfs commented Jan 14, 2019

@DJViking I didn't have the time yet to pick up this PR. And there isn't somebody else finishing the PR.

@DJViking

This comment has been minimized.

Copy link

DJViking commented Jun 12, 2019

@alexbrjo Checks have failed, conflicts must be resolved.
Then I hope someone can merge this PR.

I see someone else have picked this up by forking this PR.
#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.