Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34599] Setting of final fields #33

Merged
merged 4 commits into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

jglick commented Jul 11, 2017

Subsumes #32: effective diff (there is supposed to be some URL form append to the PR that lets you specify a commit range but I could not get it to work here)

@reviewbybees

@jglick jglick referenced this pull request Jul 11, 2017

Merged

[JENKINS-34599] Setting of final fields #132

2 of 2 tasks complete

@jglick jglick changed the title [WiP] [JENKINS-34599] Setting of final fields [JENKINS-34599] Setting of final fields Jul 12, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 12, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

abayer approved these changes Jul 18, 2017

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 18, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick merged commit 13afba1 into jenkinsci:master Jul 18, 2017

@jglick jglick deleted the jglick:final-fields-JENKINS-34599 branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.