Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trusting the default trust store #57

Merged
merged 7 commits into from Oct 9, 2019

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Oct 8, 2019

I added SSL verification tests against a docker container to confirm that SSL should error if certificate is not loaded.

It should succeed if certificate or if Skip SSL Verification is enabled.
This is a breaking change as it would always skip verification unless you had set Skip SSL Verification it would attempt but most likely fail.

fixes #53
fixes #41

@jetersen jetersen changed the title allow trusting the default trust store fix trusting the default trust store Oct 9, 2019
@jetersen jetersen merged commit 87ff56e into jenkinsci:master Oct 9, 2019
@jetersen jetersen deleted the cacertTrust branch October 9, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant