Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over the array of files to upload #23

Merged
merged 1 commit into from Nov 6, 2014

Conversation

Projects
None yet
6 participants
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

commented Aug 13, 2014

plugins » hockeyapp-plugin #53 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Aug 14, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@Sauraus

This comment has been minimized.

Copy link
Author

commented Oct 28, 2014

@orrc I will update this pull request as soon as you merge in #24

@denis-kochetkov

This comment has been minimized.

Copy link

commented Nov 5, 2014

@Sauraus, @orrc
#24 has been merged. Please update this pull request because we are preparing release soon.

@Sauraus Sauraus force-pushed the Sauraus:24255 branch from a97fd26 to d0c8bbe Nov 5, 2014

@Sauraus

This comment has been minimized.

Copy link
Author

commented Nov 5, 2014

@dkochetkov done please merge :)

@jforest

This comment has been minimized.

Copy link

commented Nov 5, 2014

Seconded!

denis-kochetkov pushed a commit that referenced this pull request Nov 6, 2014

Denis Kochetkov
Merge pull request #23 from Sauraus/24255
Iterate over the array of files to upload

@denis-kochetkov denis-kochetkov merged commit 697d7fa into jenkinsci:master Nov 6, 2014

1 check passed

default This pull request looks good
Details
@orrc

This comment has been minimized.

Copy link
Member

commented Nov 6, 2014

Out of interest, what's the use case for uploading multiple different versions in a single job (while uploading only the first dSYM/mapping/lib file found each time)?

Probably there should also be a sanity check that getNumberOldVersions() is higher than the number of files uploaded.

@Sauraus

This comment has been minimized.

Copy link
Author

commented Nov 6, 2014

@orrc This isn't about uploading multiple different versions, the use case here is when you re-sign your iOS build using multiple different profiles, the build UUID remains the same across all the IPAs that you create which allows you to have symbols for all profiles from a single build.

Because of how HockeyApp associates crashes with apps which in turn gives you the symbols, the 'clean' way of doing this would be to only upload the dSYM file for the HockeyApp ID that is actually coded in your app's HockeyApp integration, however determining at upload time which of the builds is the right one is very hard to do, so the simple approach here is to upload the dSYM file for each IPA.

@Sauraus Sauraus deleted the Sauraus:24255 branch Nov 6, 2014

@orrc

This comment has been minimized.

Copy link
Member

commented Nov 6, 2014

@Sauraus Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.