Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Plugin respects Jenkins proxy settings #42
@jjmiv Apologies for the late reply. I became a maintainer well after this PR was raised. As best as I can tell it's to respect a proxy if it is set and to better handle edge cases related to various proxy settings.
The automatic checks tell me there are conflicts that need resolving. I'll have a look at those on the weekend and see about getting this merged.
Thanks for the offer of help. I'll reach out if I need any assistance.
p.s. I think there was a very similar PR merged in the last release that also aimed to resolve proxy issues. If so that may supercede this one. I'll find out. Could be we need both?
At present, the PR is failing some checks. Probably because the master branch has moved on quite a bit since this was raised. I'll see what I can do to update this PR and bring it into line.
Company proxy set ups! Tell me about it! This may help but just in case it doesn't can you list here what exactly the issue is with your company proxy set up. Could need a separate bug raised for the plugin or (best case) this resolves the issue.
OK, this passes the server checks. Turned out to be a findbugs error but wasn't immediately clear in the logs on the build server. Happy to merge this in now.
Although if anyone is reading we're putting a lot of responsibilities in a single class. I'd appreciate some help refactoring this project.