Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a reversion of #46 from #42 #53

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@mezpahlan
Copy link

commented Sep 25, 2018

Add support for setting HOCKEYAPP_INSTALL_URL

Fix a reversion of #46 from #42.

Add support for setting HOCKEYAPP_INSTALL_URL
Fixes a reversion of #46 from #42.

@mezpahlan mezpahlan added the bug label Sep 25, 2018

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Sep 25, 2018

Hi @douglasknudsen if you are able would mind check this out? I've simply reapplied the changes that were overwritten from #46 .

@douglasknudsen

This comment has been minimized.

Copy link

commented Sep 26, 2018

great! tldr; it works

long story...I did this
git fetch upstream pull/53/head:fix-reversion-of-pr-46
git checkout fix-reversion-of-pr-46
...making sure I had the right branch
ran mvn install and uploaded the hpi file to our Jenkins server
I see this in the plugins section
screen shot 2018-09-25 at 8 37 18 pm

and in the build that deployed to hockey, where I have 3 different APKs to deploy I see in the environment var dump for debugging the following:

HOCKEYAPP_INSTALL_URL_2=https://rink.hockeyapp.net/apps/asdf/app_versions/1694
HOCKEYAPP_INSTALL_URL_1=https://rink.hockeyapp.net/apps/asdf/app_versions/1693
HOCKEYAPP_INSTALL_URL_0=https://rink.hockeyapp.net/apps/asdf/app_versions/1692

👍

@mezpahlan mezpahlan merged commit 14651de into jenkinsci:master Sep 26, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@mezpahlan mezpahlan deleted the mezpahlan:bugfix/fix-reversion-of-pr-46 branch Sep 26, 2018

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Sep 26, 2018

This will be released as 1.3.2. Massive apologies again. Give the Jenkins servers around 8 hours to propagate the new plugin to the update site but should be good to go now.

Please let me know any further issues. Thanks for reporting.

@douglasknudsen

This comment has been minimized.

Copy link

commented Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.