Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins-54498] version creation databoundconstructor regression #56

Conversation

Projects
None yet
2 participants
@mezpahlan
Copy link

commented Nov 6, 2018

Carried over from regression in #52. Attempting to make the versionCreation field optional by making better use of @DataBoundSetter functionality.

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Nov 6, 2018

Hi @MikolajKakol are you able to test these changes out? Hopefully it fixes the issue you were having.

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Nov 6, 2018

@jenkinsci/code-reviewers Could you also give this a look. The original problem was that we introduced a new parameter in the @DataBoundContructor that forced a new behaviour on existing users that really should have been optional. I think now we fall back to a sensible default if no additional parameter is explicitly set in the pipeline..... At least that's what I hope 😸

Add deprecated constructor
Needed to prevent further breakages as others (such as test classes) may
 need it.
@MikolajKakol

This comment has been minimized.

Copy link

commented Nov 7, 2018

I tested 1.4.0-SNAPSHOT (private-d9c692c6-jenkins) from https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fhockeyapp-plugin/detail/PR-56/2/artifacts
and it worked. Thx!

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Nov 7, 2018

@MikolajKakol Thank you for confirming. I'll wait until the Jenkins Code Reviewers have a look before merging.

@mezpahlan

This comment has been minimized.

Copy link
Author

commented Nov 12, 2018

I've added some tests for this confirming the new behavioural changes and hopefully should protect against further breakages.

@jenkinsci/code-reviewers If one of you has time I'd appreciate a quick look over this. The original problem was that we introduced a new parameter in the @DataBoundContructor that forced a new behaviour on existing users that really should have been optional. I think now we fall back to a sensible default if no additional parameter is explicitly set in the pipeline.

@mezpahlan mezpahlan merged commit d484957 into jenkinsci:master Nov 14, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@mezpahlan mezpahlan deleted the mezpahlan:bugfix/JENKINS-54498-version-creation-databoundconstructor-regression branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.