Skip to content
Permalink
Browse files

[JENKINS-14491] NPE reported by Jesse Jacob.

Form binding apparently neglects to pass empty lists to data-bound constructors, so check for null.
Reproducible even in 1.473 just by configuring publisher with no rows,
i.e. not actually the real problem reported in this bug (though made more apparent by it).
  • Loading branch information...
jglick committed Jul 30, 2012
1 parent 24bebc0 commit d3d24157587d9e25fb634280b1787bbbf61bb38c
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/main/java/htmlpublisher/HtmlPublisher.java
@@ -57,7 +57,7 @@

@DataBoundConstructor
public HtmlPublisher(List<HtmlPublisherTarget> reportTargets) {
this.reportTargets = new ArrayList<HtmlPublisherTarget>(reportTargets);
this.reportTargets = reportTargets != null ? new ArrayList<HtmlPublisherTarget>(reportTargets) : new ArrayList<HtmlPublisherTarget>();
}

public ArrayList<HtmlPublisherTarget> getReportTargets() {

2 comments on commit d3d2415

@mrooney

This comment has been minimized.

Copy link
Member

replied Aug 3, 2012

Awesome, thanks jglick!

@kodekraft

This comment has been minimized.

Copy link

replied Aug 9, 2012

do u have any further instructions on applying this fix? thanks

Please sign in to comment.
You can’t perform that action at this time.