New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-50026 Hubot Steps 2.0.0 #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet to write some documents
nrayapati
changed the title
JENKINS-44401 Hubot Steps 2.0.0
JENKINS-50026 Hubot Steps 2.0.0
Apr 6, 2018
bhram999
reviewed
Apr 7, 2018
README.adoc
Outdated
* *site* `optional`, hubot site name either it is from Folder Level or Global Level, Only used when *url*, *room* and *failOnError* are not present. Optional, it will fallback to first default site that it found while searching from immediate folder to Global site configurations. | ||
* *url* `optional`, if it is provided as global environment variable *HUBOT_URL* or provided by `withEnv` step, this should always end with `/`, environment variable takes the lower precedence. | ||
* *room* `optional`, if it is provided as global environment variable *HUBOT_DEFAULT_ROOM* or provided by `withEnv` step, and room doesn't require `#`, it is added in the code, environment variable takes the lower precedence. | ||
* *failOnError* `optional` and by default it is `true`, if any error it won't abort the job., it can also be provided as global environment variable *HUBOT_FAIL_ON_ERROR*, environment variable takes the lower precedence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.,
馃樁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id
,submitter
,ok
,submitterParameter
andparameters
.failOnError
- Changed type fromboolean
toString
failOnError
- Global environment variableHUBOT_FAIL_ON_ERROR
takes lower precedence forhubotSend
andhubotApprove
.hubotSend
,hubotApprove
- The message not being appended withBUILD_URL
andUser Name
anymore, instead these variable being sent through JSON, so hubot script can have some massaging.hubot_slack.coffee
in scripts folder for sample example and notes.