Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a consistent timestamp for all point generation #42

Merged
merged 6 commits into from Aug 15, 2018

Conversation

Projects
None yet
2 participants
@eugene-davis
Copy link
Contributor

commented Jul 17, 2018

Sets a single timestamp across all point generation so that all points can be aggregated into a single point (i.e. in a Grafana display). Without this, each point would run a chance of having a different time set for it, periodically breaking this functionality.

@asimell

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2018

@eugene-davis I agree that with this PR we can get more consistent data to InfluxDB. However, for example RobotFrameworkPointGenerator creates points for each suite, tag, and test case. Without having a different timestamp for each of them, InfluxDB will just overwrite previous data as it uses timestamp as the primary key. This could be fixed by allowing different timestamps to these different measurements (subpoints for rf_results).

@eugene-davis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2018

I will see what I can do about doing something along those lines soon.

eugene-davis added some commits Aug 14, 2018

@eugene-davis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

@asimell I have updated the PR to set a unique timestamp by using a time generator - which takes in a timestamp at the nanoscale and then returns the timestamp incremented by one nanosecond for each call. With how it is configured it should generate subpoint timestamps that are unique to their measurement.

@asimell

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2018

This is looking really good. Good work!

@asimell asimell merged commit ef3dc95 into jenkinsci:development Aug 15, 2018

@eugene-davis eugene-davis deleted the eugene-davis:timpstamp-everything branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.