Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NullpointerException in CustomPointDataGenerator (default measurementName) in latest release 1.18 #47

Conversation

Projects
None yet
2 participants
@nubody
Copy link
Contributor

commented Aug 17, 2018

When InfluxDbPublisher is instantiated, the default member measurementName = "jenkins_data" is overwritten.
This leads to a NullpointerException in CustomPointDataGenerator:

14:28:03 [InfluxDB Plugin] Failed to collect data. Ignoring Exception:java.lang.NullPointerException
14:28:03 ERROR: Build step failed with exception
14:28:03 java.lang.NullPointerException
14:28:03 	at jenkinsci.plugins.influxdb.generators.CustomDataPointGenerator.<init>(CustomDataPointGenerator.java:27)
14:28:03 	at jenkinsci.plugins.influxdb.InfluxDbPublisher.perform(InfluxDbPublisher.java:341)
14:28:03 	at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
14:28:03 	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
14:28:03 	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:735)
14:28:03 	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:676)
14:28:03 	at hudson.model.Build$BuildExecution.cleanUp(Build.java:196)
14:28:03 	at hudson.model.Run.execute(Run.java:1782)
14:28:03 	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
14:28:03 	at hudson.model.ResourceController.execute(ResourceController.java:97)
14:28:03 	at hudson.model.Executor.run(Executor.java:405)
Philipp Severing
Fix for NullpointerException in CustomPointDataGenerator, when (custo…
…m) measurementName is not set (default value 'jenkins_data' is overwritten, when InfluxDbPublisher is instantiated)

@nubody nubody changed the title Fix for NullpointerException in CustomPointDataGenerator (default measurementName) Fix for NullpointerException in CustomPointDataGenerator (default measurementName) in latest release 1.18 Aug 17, 2018

@nubody

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

@asimell see InfluxDB error failed to collect data after updates
I was able to observe this behaviour (NullpointerException in CustomDataPointGenerator) in some test cases, after installing Release 1.18, but it does not necessarily occur.
Until now i could not figure out whats the cause.

@asimell

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

Wow, thanks a ton! I've been struggling to reproduce this bug and you already went and fixed it!

@asimell asimell merged commit de58558 into jenkinsci:development Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.