Skip to content
Permalink
Browse files

JENKINS-23623: Fix URL in JaCoCo Coverage Column in non-default views…

…, works around JENKINS-25113
  • Loading branch information...
centic9 committed Oct 11, 2014
1 parent f2e97e9 commit 44b5d298f3b36f57bc420d333b9ba56bbbac4850
@@ -19,7 +19,7 @@
data="${coverageAmount}" align="center">
<j:choose>
<j:when test="${it.hasCoverage(job)}">
<a style="color:#${color}" href="${job.url}lastSuccessfulBuild/jacoco/">
<a style="color:#${color}" href="${jobBaseUrl}${job.shortUrl}lastSuccessfulBuild/jacoco/">
${coveragePercent}%
</a>
</j:when>

3 comments on commit 44b5d29

@jglick

This comment has been minimized.

Copy link
Member

replied Oct 25, 2014

See jenkinsci/cobertura-plugin@1a89911; I would suggest you try

href="${rootURL}/${job.url}lastSuccessfulBuild/jacoco/"

instead.

@centic9

This comment has been minimized.

Copy link
Member Author

replied Oct 26, 2014

Thanks for the tip, I adjusted it accordingly. I was looking at some other plugins and took it from there, seems usage of these URL-variables is still a bit inconsistent across plugins.

@jglick

This comment has been minimized.

Copy link
Member

replied Oct 27, 2014

Yes I plan to fix the variant used in core to serve as a better model.

Please sign in to comment.
You can’t perform that action at this time.