Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the inclusion and exclusion inputs. #74

Merged
merged 1 commit into from Aug 20, 2016

Conversation

@praveen12bnitt
Copy link
Contributor

commented Aug 12, 2016

In our project, we had to exclude a lot of generated files. These generated files are specific to each project. So we decided to have a properties file in each repository, which will have the list of generated class files name. This file will be loaded by EnvInject Plugin to set the property in the build context.

In the jacoco plugin configuration, we will use the env variable like this ${JACOCO_EXLUDE_FILES}.

This PR will make sure, the jacoco plugin expands the variable before using it.

@pmv

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2016

We have a similar use case, but would like to have the threshold numbers expanded. Not sure if that would be easy to add to this pull request or if I should create my own pull request.

@drwoods

This comment has been minimized.

Copy link

commented Aug 19, 2016

We could use this feature too, but would also like to use build parameters for the paths to Exec, Class and Source dirs, so we can parameterize our Job DSL generated builds.
+1 on the current commit

@centic9 centic9 merged commit c172c76 into jenkinsci:master Aug 20, 2016

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@centic9

This comment has been minimized.

Copy link
Member

commented Aug 20, 2016

Please provide separate PRs for additional expansions that you would like to make use of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.