Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47393] Remove signature and runtime references to CommandLauncher #79

Merged
merged 1 commit into from Oct 17, 2017

Conversation

@jglick
Copy link
Member

commented Oct 11, 2017

@jglick jglick referenced this pull request Oct 11, 2017
2 of 2 tasks complete
@reviewbybees

This comment has been minimized.

Copy link

commented Oct 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

jglick added a commit to jglick/jenkins that referenced this pull request Oct 11, 2017
@recampbell recampbell requested a review from oleg-nenashev Oct 12, 2017
Copy link
Member

left a comment

Would it be possible to do the change in a compatible way, e.g. by introducing bridge methods and requiring the detached plugin to be installed?

The change introduces a breaking change in the JTH library, and IMHO it needs to be justified at least

@jglick

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

introducing bridge methods

Oh no.

introduces a breaking change in the JTH library

Unlikely to be source-incompatible (not that we care greatly), and binary incompatibility is irrelevant.

@jglick jglick requested a review from oleg-nenashev Oct 17, 2017
Copy link
Member

left a comment

Binary compatibility may be important for things like PCT, which probably bump JTH. But I agree it's not a blocker for the test framework (though it may cause fun for plugins shipping tests artifacts).

The code itself LGTM, hence 🐝

@jglick

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2017

things like PCT, which probably bump JTH

AFAIK it does not. That was in fact one of the benefits of splitting jenkins-test-harness into its own repository and giving it an independent lifecycle: that a plugin POM could declare a specific jenkins-test-harness.version which would remain consistent even when running with a newer jenkins.version during something like PCT (or jenkinsVersions of buildPlugin, etc.).

@jglick jglick merged commit 175e6b4 into jenkinsci:master Oct 17, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@jglick jglick deleted the jglick:CommandLauncher-JENKINS-47393 branch Oct 17, 2017
@jglick jglick referenced this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.