Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50598] - Add support of running JTH with a custom WAR #99

Closed
wants to merge 2 commits into from

Conversation

3 participants
@oleg-nenashev
Copy link
Member

commented Apr 5, 2018

I am experimenting with running PCT with WARs generated by Custom WAR Packager. I would like to be able to run JTH and PCT tests against WARs instead of the dependency-based mechanism. It would allow to support things like auto-configuration of WARs which is offered by WAR packager.

  • - Custom WAR can be passed via system property
  • - It is possible to prevent replacing of bundled plugins by older dependencies (opt-in, system property)
  • - Some documentation

https://issues.jenkins-ci.org/browse/JENKINS-50598

oleg-nenashev added some commits Apr 5, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2018


@CheckForNull
private static final boolean DO_NOT_OVERRIDE_BUNDLED_PLUGINS_BY_OLDER_TEST_DEPS =
Boolean.getBoolean("jth.pluginManager.doNotOverrideBundledPluginsByOlderTestDeps");

This comment has been minimized.

Copy link
@jglick

jglick Apr 5, 2018

Member

Maybe -0 on this: I feel it makes the semantics of functional tests a bit harder to understand, and for no very compelling reason: you can already simply ensure that the WAR under test contains sufficiently new versions of the dependencies.

@raul-arabaolaza
Copy link

left a comment

LGTM, which is not much to say considering my knowledge of the JTH internals...

Just a question and that is: When would you want to not override the war's plugins with newer test dependencies?
What do you want to test in that case?

@jglick

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

Still unconvinced that there is a valid use case for this.

@raul-arabaolaza

This comment has been minimized.

Copy link

commented Jun 8, 2018

@jglick I believe i have one valid use case, integration testing of shared libraries and Jenkinsfiles.

Now that CWP supports Configuration as code you can easily define a war file that ressembles a real environment, and with this you can use Jenkinsrule to perform the testing of your shared libraries using JTH with minimum hassle, you can even use the docker fixtures to set up auxiliary services like git repos and similar.

WDYT?

@jglick

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

you can easily define a war file that ressembles a real environment, and with this you can use Jenkinsrule to perform the testing of your shared libraries using JTH

Not following. If you are using CWP, why would you not have the versions of plugins in CWP that you wanted?

@jglick

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@oleg-nenashev do you believe this is still valid?

@oleg-nenashev

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Might be, but PCT already has a number of solutions applied for this issue.
Closing since I do not plan to work on this PR ATM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.