Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48116] Proxy to StreamTaskListener not AbstractTaskListener #122

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Nov 21, 2017

An equivalent patch made directly to rvm.hpi allows jenkinsci/acceptance-test-harness#383 to pass even without jenkinsci/jenkins#3154. But I suppose this gem would need to be released and then every plugin with a dependency on ruby-runtime rebuilt in order for the fix to actually take effect. Yuck.

@reviewbybees

@jglick jglick requested review from kohsuke and oleg-nenashev Nov 21, 2017

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Nov 21, 2017

Probably it could be reworked to API Plugin if there is somebody who has lost of spare time for that.

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 21, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2017

Yeah I would have expected the gem to be packaged in the ruby-runtime plugin itself. But the gem has apparently not been released since 2012, and acc. to

curl -sL https://updates.jenkins-ci.org/update-center.json | head -2 | tail +2 | jq -r '.plugins | .[] | select(.dependencies | .[] | .name == "ruby-runtime") | .name'

there are 23 plugins using this dependency. Seems like a serious maintainability issue.

@oleg-nenashev
Copy link
Member

left a comment

🐝 whatever works

@jglick

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2017

@jglick jglick referenced this pull request Apr 6, 2018

Open

Plugin facelift + JENKINS-50616 fix for JEP-200 #6

4 of 4 tasks complete
@jglick

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2018

@daniel-beck note that when JEP-7 is implemented, this could be closed (along with any other PRs to this repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.