Skip to content
Permalink
Browse files

Javadoc notes warning that the action should be hidden if impermissible.

[JENKINS-25691] Might have prevented the need for: jenkinsci/maven-plugin#33
  • Loading branch information
jglick committed Nov 21, 2014
1 parent d237acc commit 08542cad7524ba4838922622889700e4dd7c2ce1
Showing with 9 additions and 2 deletions.
  1. +9 −2 core/src/main/java/hudson/model/TaskAction.java
@@ -60,15 +60,22 @@
protected transient WeakReference<AnnotatedLargeText> log;

/**
* Gets the permission object that represents the permission to perform this task.
* Gets the permission object that represents the permission (against {@link #getACL}) to perform this task.
* Generally your implementation of {@link #getIconFileName} should return null if {@code !getACL().hasPermission(getPermission())}.
*/
protected abstract Permission getPermission();

/**
* Gets the {@link ACL} against which the permissions are checked.
* Gets the {@link ACL} against which {@link #getPermission} is checked.
*/
protected abstract ACL getACL();

/**
* @inheritDoc
* @see #getPermission
*/
@Override public abstract String getIconFileName();

/**
* @deprecated as of 1.350
* Use {@link #obtainLog()}, which returns the same object in a more type-safe signature.

0 comments on commit 08542ca

Please sign in to comment.
You can’t perform that action at this time.