Permalink
Show file tree
Hide file tree
2 changes: 1 addition & 1 deletion
2
core/src/main/resources/lib/hudson/project/config-upstream-pseudo-trigger.jelly
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[SECURITY-55]
This patch makes standard post-build action refuse to let you configure a downstream project you cannot currently build. The one from parameterized-trigger will show an error in the configure screen but still lets you save the configuration; needs an analogous patch to that plugin. Does not yet protect against POSTing config.xml with the trigger. (cherry picked from commit 757bc8a) Conflicts: core/src/main/java/hudson/model/Descriptor.java
- Loading branch information
Showing
5 changed files
with
19 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes https://issues.jenkins-ci.org/browse/JENKINS-16917
I admit that the extension of the BuildTrigger.DescriptorImpl in DownstreamTrigger is a bit 'unconventional' (see: https://github.com/jenkinsci/downstream-ext-plugin/blob/master/src/main/java/hudson/plugins/downstream_ext/DownstreamTrigger.java#L296)
but if BuildTrigger.DescriptorImp isn't meant to be extendable it should IMHO be made final.