Skip to content
Permalink
Browse files

[FIXED JENKINS-4409] Disable URLConnection.useCache in tests on Windo…

…ws. It prevents deleting temporary directories when tests finish.

(cherry picked from commit c4e5fbd)
  • Loading branch information
ikedam authored and olivergondza committed Feb 14, 2015
1 parent 9441324 commit 9bce20951c3ffe8e83a18a5a8d5743e183ebf3a8
@@ -101,6 +101,7 @@
import java.net.URISyntaxException;
import java.net.URL;
import java.net.URLClassLoader;
import java.net.URLConnection;
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.Arrays;
@@ -276,6 +277,8 @@
*/
protected File explodedWarDir;

private boolean origDefaultUseCache = true;

protected HudsonTestCase(String name) {
super(name);
}
@@ -298,6 +301,18 @@ public void runBare() throws Throwable {

@Override
protected void setUp() throws Exception {
if(Functions.isWindows()) {
// JENKINS-4409.
// URLConnection caches handles to jar files by default,
// and it prevents delete temporary directories on Windows.
// Disables caching here.
// Though defaultUseCache is a static field,
// its setter and getter are provided as instance methods.
URLConnection aConnection = new File(".").toURI().toURL().openConnection();
origDefaultUseCache = aConnection.getDefaultUseCaches();
aConnection.setDefaultUseCaches(false);
}

env.pin();
recipe();
for (Runner r : recipes) {
@@ -420,6 +435,12 @@ protected void tearDown() throws Exception {
// at some later point, leading to possible file descriptor overflow. So encourage GC now.
// see http://bugs.sun.com/view_bug.do?bug_id=4950148
System.gc();

// restore defaultUseCache
if(Functions.isWindows()) {
URLConnection aConnection = new File(".").toURI().toURL().openConnection();
aConnection.setDefaultUseCaches(origDefaultUseCache);
}
}
}

@@ -128,6 +128,7 @@
import java.net.URISyntaxException;
import java.net.URL;
import java.net.URLClassLoader;
import java.net.URLConnection;
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.Arrays;
@@ -303,6 +304,8 @@

public JenkinsComputerConnectorTester computerConnectorTester = new JenkinsComputerConnectorTester(this);

private boolean origDefaultUseCache = true;

public Jenkins getInstance() {
return jenkins;
}
@@ -312,6 +315,18 @@ public Jenkins getInstance() {
* @throws Throwable if setup fails (which will disable {@code after}
*/
public void before() throws Throwable {
if(Functions.isWindows()) {
// JENKINS-4409.
// URLConnection caches handles to jar files by default,
// and it prevents delete temporary directories on Windows.
// Disables caching here.
// Though defaultUseCache is a static field,
// its setter and getter are provided as instance methods.
URLConnection aConnection = new File(".").toURI().toURL().openConnection();
origDefaultUseCache = aConnection.getDefaultUseCaches();
aConnection.setDefaultUseCaches(false);
}

// Not ideal (https://github.com/junit-team/junit/issues/116) but basically works.
if (Boolean.getBoolean("ignore.random.failures")) {
RandomlyFails rf = testDescription.getAnnotation(RandomlyFails.class);
@@ -458,6 +473,12 @@ public void after() throws Exception {
// see http://bugs.sun.com/view_bug.do?bug_id=4950148
// TODO use URLClassLoader.close() in Java 7
System.gc();

// restore defaultUseCache
if(Functions.isWindows()) {
URLConnection aConnection = new File(".").toURI().toURL().openConnection();
aConnection.setDefaultUseCaches(origDefaultUseCache);
}
}
}

0 comments on commit 9bce209

Please sign in to comment.
You can’t perform that action at this time.