Skip to content
Permalink
Browse files

Revert "Updating Guava."

This reverts commit d45d18e.
  • Loading branch information...
kohsuke committed Oct 27, 2013
1 parent 206efb8 commit cfe4b82994f261fe7623becfd2c7505679284026
Showing with 2 additions and 2 deletions.
  1. +1 −1 core/src/main/java/hudson/util/RunList.java
  2. +1 −1 pom.xml
@@ -133,7 +133,7 @@ public R get(int index) {
public List<R> subList(int fromIndex, int toIndex) {
List<R> r = new ArrayList<R>();
Iterator<R> itr = iterator();
Iterators.advance(itr,fromIndex);
Iterators.skip(itr,fromIndex);
for (int i=toIndex-fromIndex; i>0; i--) {
r.add(itr.next());
}
@@ -179,7 +179,7 @@ THE SOFTWARE.
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>15.0</version>
<version>11.0.1</version>
</dependency>

<dependency>

7 comments on commit cfe4b82

@btiernay

This comment has been minimized.

Copy link

replied Aug 18, 2014

Very curious why this was reverted. This is causing some pain in JENKINS-22252. Care to comment?

@christ66

This comment has been minimized.

Copy link
Member

replied Aug 19, 2014

@btiernay Upgrading guava cannot easily be done. The guava deprecated list indicates that they are removing methods from guava which cause breakage in other plugins since a lot of plugins depend on guava from core. An example of this is the Closeables that was deprecated in v14 and removed in v16. See Issue-1309.

If this plugin requires version v15 of guava, they could add the maven hpi pluginFirstClassLoader argument which would load v15 before loading the the core version.

@btiernay

This comment has been minimized.

Copy link

replied Aug 19, 2014

@christ66 much appreciated. Thanks for elucidating.

@lewisd32

This comment has been minimized.

Copy link

replied Sep 10, 2014

Could guava be upgraded to at least the latest version that doesn't remove deprecated methods? This may fix JENKINS-22252 still.
The patch I see above upgrades guava to 15.0. Your comment says the deprecated methods were removed in 16, so wouldn't 15 still be fine?

@btiernay

This comment has been minimized.

Copy link

replied Sep 10, 2014

Ah, touche. This could get very interesting very quickly

@timbru31

This comment has been minimized.

Copy link
Contributor

replied Sep 15, 2014

I would love to see the upgrade to guava 15 again :)
(was already implemented once, but reverted again: cfe4b82)

@kohsuke

This comment has been minimized.

Copy link
Member Author

replied Sep 15, 2014

My suggestion is to build a new core with the change, and see if the major plugins will continue to work or break left and right.

Please sign in to comment.
You can’t perform that action at this time.