Skip to content
Permalink
Browse files

[JENKINS-16917] hudson.plugins.downstream_ext.DownstreamTrigger.Descr…

…iptorImpl should not be extending BuildTrigger.DescriptorImpl since it does not produce a BuildTrigger from newInstance.

(Generally there is no reason to subclass a Descriptor type which is already an @extension rather than an explicit abstract supertype, but this is a bit more conservative change than just making it final.)
  • Loading branch information
jglick committed Feb 21, 2013
1 parent 940d743 commit fd0657ef9e34f8ce9c8802babec3873f8133ca99
Showing with 1 addition and 1 deletion.
  1. +1 −1 core/src/main/java/hudson/tasks/BuildTrigger.java
@@ -296,7 +296,7 @@ public String getHelpFile() {
}

@Override
public Publisher newInstance(StaplerRequest req, JSONObject formData) throws FormException {
public BuildTrigger newInstance(StaplerRequest req, JSONObject formData) throws FormException {
String childProjectsString = formData.getString("childProjects").trim();
if (childProjectsString.endsWith(",")) {
childProjectsString = childProjectsString.substring(0, childProjectsString.length() - 1).trim();

0 comments on commit fd0657e

Please sign in to comment.
You can’t perform that action at this time.