Permalink
Commits on Nov 30, 2016
  1. Merge pull request #2654 from batmat/improvehudson.Extension.ordinal

    Clarify hudson.Extension#ordinal documentation
    daniel-beck committed on GitHub Nov 30, 2016
  2. Clarify hudson.Extension#ordinal documentation

    I have to read it many times each time I need it. Hopefully
    it's a bit clearer with this addition.
    batmat committed Nov 30, 2016
Commits on Nov 29, 2016
Commits on Nov 28, 2016
  1. Merge pull request #2646 from batmat/add-level-to-SystemProperties

    Be able to specify the log Level when system property is not found
    batmat committed on GitHub Nov 28, 2016
Commits on Nov 27, 2016
  1. updated changelog for release

    kohsuke committed Nov 27, 2016
  2. Don't mention #2632

    It's not actually a change in anything we deliver.
    daniel-beck committed on GitHub Nov 27, 2016
  3. Update winp to 1.24. In particular, it addresses issues like [JENKINS…

    …-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619)
    
    ### Changes to be picked
    
    ### 1.24
    
    Release date: Nov 2, 2016
    
    * [Issue #22](kohsuke/winp#22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](kohsuke/winp#23))
    * [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](kohsuke/winp#20))
    * [Issue #24](kohsuke/winp#24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](kohsuke/winp#25))
    * [Issue #26](kohsuke/winp#26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](kohsuke/winp#27))
    
    ### 1.23
    
    Release date: Fev 16, 2015
    
    * Migrate native components to Visual Studio Community 2013. ([PR #14](kohsuke/winp#14))
    * Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](kohsuke/winp#12))
    oleg-nenashev committed on GitHub Nov 27, 2016
  4. [JENKINS-39805] - Update SSH module to 1.8 (#2641)

    `the fix disables some obsolete protocols as per [JENKINS-39805](https://issues.jenkins-ci.org/browse/JENKINS-39805):  AES128CBC, TripleDESCBC.Factory(), and BlowfishCBC
    
    All changes: jenkinsci/sshd-module@sshd-1.7...sshd-1.8
    oleg-nenashev committed on GitHub Nov 27, 2016
  5. [JENKINS-38867] Optimize performance of Actionable.getAllActions (#2582)

    * Optimize Actionable.getAllActions.
    
    * Also need to invalidate the cache when new plugins are installed.
    
    * Various improvements to TransientActionFactory caching.
    · Move the cache code to TransientActionFactory itself, for better encapsulation.
    · Optimize getAction(Class) to not need to call getAllActions; avoids copying lists, and can avoid calling TransientActionFactory at all.
    · Ensure that we maintain a separate cache per ExtensionList instance, so that static state is not leaked across Jenkins restarts.
    
    * Updated TransientActionFactory to specify what kinds of actions it could produce.
    
    * It turns out that changing type parameters for an extension, while generally binary-compatible, breaks reflective code in Jenkins and so this is not an option.
    … hudson.ExtensionFinder$GuiceFinder$SezpozModule configure
    WARNING: Failed to load com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
    java.lang.LinkageError: Failed to resolve class com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
    	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:489)
    	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:506)
    	at …
    	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:280)
    	at …
    	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:472)
    	at hudson.ExtensionList.load(ExtensionList.java:349)
    	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:287)
    	at hudson.ExtensionList.getComponents(ExtensionList.java:167)
    	at jenkins.model.Jenkins$8.onInitMilestoneAttained(Jenkins.java:1082)
    	at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:82)
    	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:104)
    	at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:176)
    	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    	at java.lang.Thread.run(Thread.java:745)
    Caused by: java.lang.reflect.MalformedParameterizedTypeException
    	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.validateConstructorArguments(ParameterizedTypeImpl.java:58)
    	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.<init>(ParameterizedTypeImpl.java:51)
    	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.make(ParameterizedTypeImpl.java:92)
    	at sun.reflect.generics.factory.CoreReflectionFactory.makeParameterizedType(CoreReflectionFactory.java:105)
    	at sun.reflect.generics.visitor.Reifier.visitClassTypeSignature(Reifier.java:140)
    	at sun.reflect.generics.tree.ClassTypeSignature.accept(ClassTypeSignature.java:49)
    	at sun.reflect.generics.repository.ClassRepository.getSuperclass(ClassRepository.java:90)
    	at java.lang.Class.getGenericSuperclass(Class.java:777)
    	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:470)
    	... 29 more
    
    * Remove actionType override to make for a simpler diff.
    
    * Strengthened test to cover accesses to unrelated context types.
    
    * Strengthening tests in a couple of ways.
    
    * Javadoc improvements suggested by @oleg-nenashev.
    jglick committed with oleg-nenashev Nov 27, 2016
Commits on Nov 25, 2016
  1. Be able to specify the log Level when system property is not found or…

    … invalid
    
    Some properties are more important than others. One may for example
     want to log a WARNING instead of the current default CONFIG
    when some property can not be found, or has an invalid format
    (like a string, when asking for an Integer).
    batmat committed Nov 25, 2016
Commits on Nov 22, 2016
Commits on Nov 20, 2016
  1. updated changelog for release

    kohsuke committed Nov 20, 2016
Commits on Nov 19, 2016
  1. [JENKINS-23271] - Prevent early deallocation of the Proc instance by …

    …GC in ProcStarter#join() (#2635)
    
    * [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC
    
    It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join().
    
    This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers)
    
    This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit
    
    * [JENKINS-23271] - Get rid of the procHolderForJoin field
    
    * [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed
    
    * Remove assert
    oleg-nenashev committed on GitHub Nov 19, 2016
  2. Merge pull request #2633 from jglick/remoting.jar

    Stop storing three identical copies of remoting.jar in jenkins.war
    daniel-beck committed on GitHub Nov 19, 2016
  3. Merge pull request #2637 from jglick/TokenBasedRememberMeServices2Tes…

    …t-LoggerRule
    
    Take advantage of LoggerRule to simplify test
    daniel-beck committed on GitHub Nov 19, 2016
  4. [FIX JENKINS-39034] /i18n/resourceBundle should be conform to the w3c…

    … standard about locale negotiation (#2594)
    
    * [parseCountry] Extract region/country and variant from the language parameter in case it is bigger then 2 letters. Add tests for both cases.
    
    * [JENKINS-39034] remove debug system out
    
    * [JENKINS-39034] Only if we have 5 or more character we want to get the country - prevent NPE
    
    * [JENKINS-39034] use split since it is more general
    
    * [JENKINS-39034] Only override country and variant if not already set
    
    * [JENKINS-39034] better test cases to test whether the fallback and variant resolving work corret
    
    * [JENKINS-39034] remove duplicate tests and better name existing ones
    scherler committed with oleg-nenashev Nov 19, 2016
  5. Merge pull request #2636 from alvarolobato/JENKINS-39741-2

    [JENKINS-39741] - Redirect to login page after authorisation error when checking connectivity to update center and handle any other error.
    daniel-beck committed on GitHub Nov 19, 2016
  6. Merge pull request #2640 from damianszczepanik/translations

    Polish translations for settings
    daniel-beck committed on GitHub Nov 19, 2016
  7. Polish translations for settings

    damianszczepanik committed Nov 13, 2016
Commits on Nov 16, 2016
  1. Add changelog for 2.32

    daniel-beck committed on GitHub Nov 16, 2016
  2. updated changelog for release

    kohsuke committed Nov 16, 2016
Commits on Nov 15, 2016
  1. Take advantage of LoggerRule to simplify test.

    jglick committed Nov 15, 2016
  2. [JENKINS-39741] - Redirect to login page after authorisation error wh…

    …en checking connectivity to update center and handle any other error.
    alvarolobato committed Nov 15, 2016