[JENKINS-61692] "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException #11438

Activity

1. jenkins-infra-bot commented on Mar 26, 2020

   

   jenkins-infra-bot

   on Mar 26, 2020

   Author

   More actions

   • Remote link associated with this issue:

     • PR 4607
2. jenkins-infra-bot commented on Mar 26, 2020

   

   jenkins-infra-bot

   on Mar 26, 2020

   Author

   More actions

   oleg_nenashev:

   • Original comment link
   • Raw content of original comment:

     There is no recent changes in Secret.java or Stapler which would cause that behavior AFAICT. I assume that the nll check is missing in the code, but I am not sure what causes it to be passed
     
     static { 
       Stapler.CONVERT_UTILS.register(new org.apache.commons.beanutils.Converter() { 
         public Secret convert(Class type, Object value) { 
     306:      return Secret.fromString(value.toString()); 
     } }, Secret.class); }
     
     
     

   There is no recent changes in Secret.java or Stapler which would cause that behavior AFAICT. I assume that the nll check is missing in the code, but I am not sure what causes it to be passed

   static { 
     Stapler.CONVERT_UTILS.register(new org.apache.commons.beanutils.Converter() { 
       public Secret convert(Class type, Object value) { 
   306:      return Secret.fromString(value.toString()); 
   } }, Secret.class); }
   
3. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   danielbeck:

   • Original comment link
   • Raw content of original comment:

     https://jenkins.io/doc/upgrade-guide/2.222/#redesigned-password-form-field ?
     

   https://jenkins.io/doc/upgrade-guide/2.222/#redesigned-password-form-field ?
4. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   thomaspatzig:

   • Original comment link
   • Raw content of original comment:

     have try to add system property
       <arguments>-Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"</arguments>
     
     same error
     
     and the system property is not know:
       
     

   have try to add system property
   -Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"

   same error

   and the system property is not know:
   
5. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   thomaspatzig:

   • Original comment link
   • Raw content of original comment:

     @danielbeck, @oleg_nenashev
     ..are you able to reproduce? It doesn't matter what you enter it will crash: 
      
     

   @danielbeck, @oleg_nenashev
   ..are you able to reproduce? It doesn't matter what you enter it will crash:
   
6. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   thomaspatzig:

   • Original comment link
   • Raw content of original comment:

     secretPassword is no longer stored in proxy.xml
     is this the reason?
     
       
     

   secretPassword is no longer stored in proxy.xml
   is this the reason?

   
7. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   danielbeck:

   • Original comment link
   • Raw content of original comment:

     and the system property is not know:
     That's because you're doing it wrong. System properties go before '-jar' argument.
     

   and the system property is not know:

   That's because you're doing it wrong. System properties go before '-jar' argument.
8. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   danielbeck:

   • Original comment link
   • Raw content of original comment:

     Based on latest comment, pinging timja from JENKINS-56553.
     

   Based on latest comment, pinging timja from JENKINS-56553.
9. jenkins-infra-bot commented on Mar 27, 2020

   

   jenkins-infra-bot

   on Mar 27, 2020

   Author

   More actions

   thomaspatzig:

   • Original comment link
   • Raw content of original comment:

     ok... changed the order of parameters:
      
     
     ...same behavior....nothing changed
        
     

   ok... changed the order of parameters:
   

   ...same behavior....nothing changed
   
10. jenkins-infra-bot commented on Mar 27, 2020

    

    jenkins-infra-bot

    on Mar 27, 2020

    Author

    More actions

    thomaspatzig:

    • Original comment link
    • Raw content of original comment:

      ...and I don't use any plugin... no JCasC.
      

    ...and I don't use any plugin... no JCasC.
11. jenkins-infra-bot commented on Mar 27, 2020

    

    jenkins-infra-bot

    on Mar 27, 2020

    Author

    More actions

    danielbeck:

    • Original comment link
    • Raw content of original comment:

      Looks like a regression in 2.205:
      
      secretPassword gets set: 
      
        
      
          
      
            jenkins/core/src/main/resources/hudson/ProxyConfiguration/config.groovy
          
          
      
               Line 15
            in
            489e4b3
          
        
        
      
          
      
      
              
      
                
      
                
       f.password() 
              
          
        
      
      
      
      Form validation uses password which doesn't exist: 
      
        
      
          
      
            jenkins/core/src/main/resources/hudson/ProxyConfiguration/config.groovy
          
          
      
               Line 25
            in
            489e4b3
          
        
        
      
          
      
      
              
      
                
      
                
       method:"validateProxy", with:"testUrl,name,port,userName,password,noProxyHost") 
              
          
        
      
      
      
      thomaspatzig Could you clarify whether this affects only form validation ("Validate Proxy") or whether saving the password doesn't work either?
      

    Looks like a regression in 2.205:

    secretPassword gets set:

    jenkins/core/src/main/resources/hudson/ProxyConfiguration/config.groovy

    Line 15 in 489e4b3

    f.password()

    Form validation uses password which doesn't exist:

    jenkins/core/src/main/resources/hudson/ProxyConfiguration/config.groovy

    Line 25 in 489e4b3

    method:"validateProxy", with:"testUrl,name,port,userName,password,noProxyHost")

    ---

    thomaspatzig Could you clarify whether this affects only form validation ("Validate Proxy") or whether saving the password doesn't work either?
12. jenkins-infra-bot commented on Mar 27, 2020

    

    jenkins-infra-bot

    on Mar 27, 2020

    Author

    More actions

    thomaspatzig:

    • Original comment link
    • Raw content of original comment:

      ..can't access the links....
      
       
      
      ...but AFAIK it is only on validation. "submit" works... 
      
       
      
      but then the other issue happens: proxy doesn't work with git...  https://issues.jenkins-ci.org/browse/JENKINS-61693
      

    ..can't access the links....

     

    ...but AFAIK it is only on validation. "submit" works... 

     

    but then the other issue happens: proxy doesn't work with git...  https://issues.jenkins-ci.org/browse/JENKINS-61693
13. jenkins-infra-bot commented on Mar 27, 2020

    

    jenkins-infra-bot

    on Mar 27, 2020

    Author

    More actions

    danielbeck:

    • Original comment link
    • Raw content of original comment:

      ...but AFAIK it is only on validation. "submit" works...
      Thanks for the clarification.
      

    ...but AFAIK it is only on validation. "submit" works...

    Thanks for the clarification.
14. jenkins-infra-bot commented on Mar 28, 2020

    

    jenkins-infra-bot

    on Mar 28, 2020

    Author

    More actions

    thomaspatzig:

    • Original comment link
    • Raw content of original comment:

      ..have try jenkins.war from PR 4607.... it works...
      
       
      
      have also found a mistake on my side....
      
      I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...
      
       
      
      for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"...
      
      (same on http post pluginManager/proxyConfigure)
      
       
      
      I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)
      
       
      
      ....with fix on my side ("secretPassword" instead of "password") it works fine.
      

    ..have try jenkins.war from PR 4607.... it works...

     

    have also found a mistake on my side....

    I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...

     

    for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"...

    (same on http post pluginManager/proxyConfigure)

     

    I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

     

    ....with fix on my side ("secretPassword" instead of "password") it works fine.
15. jenkins-infra-bot commented on Mar 28, 2020

    

    jenkins-infra-bot

    on Mar 28, 2020

    Author

    More actions

    danielbeck:

    • Original comment link
    • Raw content of original comment:

      I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)
      
      ....with fix on my side ("secretPassword" instead of "password") it works fine.
      That's correct; you're effectively saving the configuration without password when using the obsolete name.
      

    I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

    ....with fix on my side ("secretPassword" instead of "password") it works fine.

    That's correct; you're effectively saving the configuration without password when using the obsolete name.
16. jenkins-infra-bot

    closed this as completedon Mar 28, 2020
17. jenkins-infra-bot

    added

    bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

    regression

    imported-jira-issue

    component:core

    priority:minor

    resolution:fixed

    on Nov 24, 2025
18. jenkins-infra-bot

    added the

    Bug

    issue type on Nov 24, 2025
19. jenkins-infra-bot

    removed

    bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

    on Nov 24, 2025