Repository navigation
[JENKINS-61808] Always encrypt f:password values, not just those backed by Secret #11456
Description
Too many people get the Secret getters wrong. What if we just always returned a Secret, and had a StringConverter to handle submitted secrets and transparently decrypt again?
This would eliminate this class of problem. Only storage would really need to be done as Secret, but the internal API types wouldn't matter so much.
Test cases need to include String typed encrypted secrets, and unmatched getter/setter types.
Originally reported by 
danielbeck, imported from: Always encrypt f:password values, not just those backed by Secret
- assignee: danielbeck
- status: Resolved
- priority: Minor
- component(s): core
- label(s): security
- resolution: Fixed
- resolved: 2020-05-19T22:15:40+00:00
- votes: 0
- watchers: 2
- imported: 2025-11-24
Raw content of original issue
Too many people get the Secret getters wrong. What if we just always returned a Secret, and had a StringConverter to handle submitted secrets and transparently decrypt again?
This would eliminate this class of problem. Only storage would really need to be done as Secret, but the internal API types wouldn't matter so much.
Test cases need to include String typed encrypted secrets, and unmatched getter/setter types.
Activity
jenkins-infra-bot commentedon Apr 4, 2020
Remote link associated with this issue: