Skip to content

[JENKINS-12680] onOffline in ComputerListener not getting called when node is taken offline #12448

Closed

Description

@jenkins-infra-bot

In ComputerListener, onOffline is only called if a node is taken down with the disconnect link in jenkins, any other cause for a node to go offline, makes the call postponed until the master is taken down.


Originally reported by jenschristensen, imported from: onOffline in ComputerListener not getting called when node is taken offline
  • status: Resolved
  • priority: Major
  • component(s): core
  • label(s): ComputerListener, jenkins, onOffline, slave
  • resolution: Fixed
  • resolved: 2012-02-09T17:36:44+00:00
  • votes: 0
  • watchers: 1
  • imported: 2025-11-24
Raw content of original issue

In ComputerListener, onOffline is only called if a node is taken down with the disconnect link in jenkins, any other cause for a node to go offline, makes the call postponed until the master is taken down.

  • environment: OS: All

Activity

  1. jenkins-infra-bot commented on Feb 9, 2012

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Kohsuke Kawaguchi
    Path:
    changelog.html
    core/src/main/java/hudson/slaves/SlaveComputer.java
    test/src/test/java/hudson/slaves/JNLPLauncherTest.java
    http://jenkins-ci.org/commit/jenkins/4378e878ae327a954911ae4ef84679e0060b63e2
    Log:
    [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination

    Compare: dd0f362...4378e87

  2. jenkins-infra-bot commented on Feb 9, 2012

    @jenkins-infra-bot
    Author
    dogfood:
    • Original comment link
    • Raw content of original comment:

      Integrated in jenkins_main_trunk #1523 [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination (Revision 4378e878ae327a954911ae4ef84679e0060b63e2)

      Result = SUCCESS Kohsuke Kawaguchi : 4378e878ae327a954911ae4ef84679e0060b63e2 Files :

      • test/src/test/java/hudson/slaves/JNLPLauncherTest.java
      • core/src/main/java/hudson/slaves/SlaveComputer.java
      • changelog.html

    Integrated in jenkins_main_trunk #1523
    [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination (Revision 4378e87)

    Result = SUCCESS
    Kohsuke Kawaguchi : 4378e878ae327a954911ae4ef84679e0060b63e2
    Files :

    • test/src/test/java/hudson/slaves/JNLPLauncherTest.java
    • core/src/main/java/hudson/slaves/SlaveComputer.java
    • changelog.html
  3. removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions