[JENKINS-16337] SSH public key field in the user config page lacks form validation #13212

Activity

1. jenkins-infra-bot commented on Jan 14, 2013

   

   jenkins-infra-bot

   on Jan 14, 2013

   Author

   More actions

   • Remote links associated with this issue:

     • ssh-cli-auth PR 4
     • core PR 2840
2. jenkins-infra-bot commented on Apr 7, 2017

   

   jenkins-infra-bot

   on Apr 7, 2017

   Author

   More actions

   jglick:

   • Original comment link
   • Raw content of original comment:

     This is in the core (specifically the ssh-cli-auth module), not the ssh plugin.
     
     AFAICT it does no parsing whatsoever of what you enter. It just splits it by newline, and then when authenticating, generates an expected public key string and does a String.equals against each line in turn.
     

   This is in the core (specifically the ssh-cli-auth module), not the ssh plugin.

   AFAICT it does no parsing whatsoever of what you enter. It just splits it by newline, and then when authenticating, generates an expected public key string and does a String.equals against each line in turn.
3. jenkins-infra-bot commented on Apr 11, 2017

   

   jenkins-infra-bot

   on Apr 11, 2017

   Author

   More actions

   scm_issue_link:

   • Original comment link
   • Raw content of original comment:

     Code changed in jenkins
     User: Jesse Glick
     Path:
      src/main/java/org/jenkinsci/main/modules/cli/auth/ssh/UserPropertyImpl.java
      src/test/java/org/jenkinsci/main/modules/cli/auth/ssh/TheTest.java
     http://jenkins-ci.org/commit/ssh-cli-auth-module/da9030294137c89b5f213a87c4ce081e9c80fac5
     Log:
       [FIXED JENKINS-16337] Provide basic syntactic validation of public keys.
     Does not try to actually decode them.
     
     
     

   Code changed in jenkins
   User: Jesse Glick
   Path:
   src/main/java/org/jenkinsci/main/modules/cli/auth/ssh/UserPropertyImpl.java
   src/test/java/org/jenkinsci/main/modules/cli/auth/ssh/TheTest.java
   http://jenkins-ci.org/commit/ssh-cli-auth-module/da9030294137c89b5f213a87c4ce081e9c80fac5
   Log:
   [FIXED JENKINS-16337] Provide basic syntactic validation of public keys.
   Does not try to actually decode them.
4. jenkins-infra-bot commented on Apr 12, 2017

   

   jenkins-infra-bot

   on Apr 12, 2017

   Author

   More actions

   scm_issue_link:

   • Original comment link
   • Raw content of original comment:

     Code changed in jenkins
     User: Jesse Glick
     Path:
      war/pom.xml
     http://jenkins-ci.org/commit/jenkins/24df43fa448efae530da9ed8d816a1ba3541bbcb
     Log:
       Merge pull request #2840 from jglick/ssh-cli-auth-JENKINS-16337
     
     JENKINS-16337 ssh-cli-auth 1.4
     
     
     Compare: 1c67022...24df43f
     
     

   Code changed in jenkins
   User: Jesse Glick
   Path:
   war/pom.xml
   http://jenkins-ci.org/commit/jenkins/24df43fa448efae530da9ed8d816a1ba3541bbcb
   Log:
   Merge pull request #2840 from jglick/ssh-cli-auth-JENKINS-16337

   JENKINS-16337 ssh-cli-auth 1.4

   Compare: 1c67022...24df43f
5. jenkins-infra-bot

   closed this as completedon Apr 12, 2017
6. jenkins-infra-bot commented on Apr 15, 2017

   

   jenkins-infra-bot

   on Apr 15, 2017

   Author

   More actions

   oleg_nenashev:

   • Original comment link
   • Raw content of original comment:

     Integrated towards 2.55
     

   Integrated towards 2.55
7. jenkins-infra-bot

   added

   bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

   ux

   imported-jira-issue

   component:core

   priority:major

   resolution:fixed

   on Nov 24, 2025
8. jenkins-infra-bot

   added the

   Bug

   issue type on Nov 25, 2025
9. jenkins-infra-bot

   removed

   bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

   on Nov 25, 2025