Repository navigation
[JENKINS-1031] Log messages on changes page do not wrap. #13856
Description
Subversion commit messages do not wrap if they do not contain line breaks.
When rendered as HTML, all of the spaces are replaced with , which
prevents the wrapping. I don't think this is particularly useful behaviour
since it means lots of horizontal scrolling when the message is long.
Originally reported by dwdyer, imported from: Log messages on changes page do not wrap.
- assignee: dwdyer
- status: Closed
- priority: Major
- component(s): core
- resolution: Fixed
- resolved: 2007-11-22T12:08:16+00:00
- votes: 0
- watchers: 0
- imported: 2025-11-24
Raw content of original issue
Subversion commit messages do not wrap if they do not contain line breaks. When rendered as HTML, all of the spaces are replaced with , which prevents the wrapping. I don't think this is particularly useful behaviour since it means lots of horizontal scrolling when the message is long.
- environment:
Platform: All, OS: All
Activity
jenkins-infra-bot commentedon Nov 21, 2007
dwdyer:
Raw content of original comment:
Fixed in version 1.36 of Util.java. Modified the escape(String) method so that
it doesn't replace spaces with HTML non-breaking space entities. Should be in
Hudson 1.159.
jenkins-infra-bot commentedon Nov 21, 2007
Raw content of original comment:
I agree that we should render Subversion commit messages to allow wrapping, but
I have a problem with this change.
I think Util.espcae should remain faithful conversion from ascii text to HTML.
Not converting whitespace to means consective whitespaces will be
combined into one.
I suggest we handle this differently. We should convert like:
'abc def' -> 'abc def'
'abc def' -> 'abc def'
'abc def' -> 'abc def'
'abc def' -> 'abc def'
'abc def' -> 'abc def'
In this way we can allow line wraps but without incorrectly trimming whitespaces.
jenkins-infra-bot commentedon Nov 22, 2007
dwdyer:
Raw content of original comment:
OK. I'll take a look at doing it the way that you suggest when I get some time
later today.
jenkins-infra-bot commentedon Nov 22, 2007
dwdyer:
Raw content of original comment:
I've just checked in a change (version 1.37 of Util.java) that implements the
space-escaping as suggested. Tested locally and it seems fine.