Skip to content

[JENKINS-2317] Patch avoiding the need for a horizontal scrollbar in the browser #14050

Description

@jenkins-infra-bot

When for example on /hudson/configure the executables sh or cvs can't be located
the error message might cause a horizontal scrollbar to appear in the browser if
the PATH is rather long. This is rather annoying if you then open an elaborate
help text which requires a lot of scrolling left and right.

This patch makes use of the tokenized diretories to create a ', ' separate list
to allow the browser to wrap the line easier.

When I tested this patch I noticed that the QuotedStringTokenizer mangled my
windows directory paths. C:\WINDOWS\system32 came out as C:WINDOWSsystem32.
Which explained why it couldn't locate cvs even when it is on the path. I
patched this also in the FormFieldValidator by replace \ with
just before the
PATH is tokenized. This does the trick. But the question remains if this
problem occurs in other situations?


Originally reported by jjasper, imported from: Patch avoiding the need for a horizontal scrollbar in the browser
  • assignee: jjasper
  • status: Closed
  • priority: Major
  • component(s): core
  • resolution: Fixed
  • resolved: 2008-09-06T11:28:15+00:00
  • votes: 0
  • watchers: 0
  • imported: 2025-11-24
Raw content of original issue

When for example on /hudson/configure the executables sh or cvs can't be located the error message might cause a horizontal scrollbar to appear in the browser if the PATH is rather long. This is rather annoying if you then open an elaborate help text which requires a lot of scrolling left and right.

This patch makes use of the tokenized diretories to create a ', ' separate list to allow the browser to wrap the line easier.

When I tested this patch I noticed that the QuotedStringTokenizer mangled my windows directory paths. C:\WINDOWS\system32 came out as C:WINDOWSsystem32. Which explained why it couldn't locate cvs even when it is on the path. I patched this also in the FormFieldValidator by replace \ with
just before the PATH is tokenized. This does the trick. But the question remains if this problem occurs in other situations?

  • environment: Platform: All, OS: All
1 attachment

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions