Skip to content

[JENKINS-2379] Build artifacts with colons in their name don't work #14063

Closed
Bug
Closed
[JENKINS-2379] Build artifacts with colons in their name don't work#14063
Bug
Labels
component:coreimported-jira-issuepriority:majorresolution:fixed

Description

@jenkins-infra-bot
jenkins-infra-bot
opened on Sep 17, 2008

If I have a build artifact with a colon in the file name it is displayed
properly, but the URL it the filename itself, without the whole http://
blah.blah/blah.

I will attach screen images with tooltips to show what I mean.

Originally reported by pgweiss, imported from: Build artifacts with colons in their name don't work
  • assignee: mindless
  • status: Closed
  • priority: Major
  • component(s): core
  • resolution: Fixed
  • resolved: 2009-01-02T11:18:08+00:00
  • votes: 0
  • watchers: 0
  • imported: 2025-11-24
Raw content of original issue 
If I have a build artifact with a colon in the file name it is displayed 
properly, but the URL it the filename itself, without the whole http://
blah.blah/blah.



I will attach screen images with tooltips to show what I mean.
  • environment: Platform: All, OS: All
2 attachments

Activity

  1. jenkins-infra-bot commented on Sep 17, 2008

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2008
    Author
    pgweiss:
    • Original comment link
    • Raw content of original comment: 
      Created an attachment (id=384)
The bad link (see tooltip)

    Created an attachment (id=384)
    The bad link (see tooltip)

  2. jenkins-infra-bot commented on Sep 17, 2008

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2008
    Author
    pgweiss:
    • Original comment link
    • Raw content of original comment: 
      Created an attachment (id=385)
The correct link (see tooltip)

    Created an attachment (id=385)
    The correct link (see tooltip)

  3. jenkins-infra-bot commented on Jan 1, 2009

    @jenkins-infra-bot
    jenkins-infra-bot
    on Jan 1, 2009
    Author
    mindless:
    • Original comment link
    • Raw content of original comment: 
      Working on this.. all items there are written as href="name", ie just a relative
pathname... it is not urlencoded, so your browser interprets stuff:morestuff as
stuff: being the protocol for the link.. need to urlencode.

    Working on this.. all items there are written as href="name", ie just a relative
    pathname... it is not urlencoded, so your browser interprets stuff:morestuff as
    stuff: being the protocol for the link.. need to urlencode.

  4. jenkins-infra-bot commented on Jan 1, 2009

    @jenkins-infra-bot
    jenkins-infra-bot
    on Jan 1, 2009
    Author
    mindless:
    • Original comment link
    • Raw content of original comment: 
      started

    started

  5. jenkins-infra-bot commented on Jan 2, 2009

    @jenkins-infra-bot
    jenkins-infra-bot
    on Jan 2, 2009
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/model/DirectoryBrowserSupport.java
 trunk/hudson/main/core/src/main/java/hudson/model/Run.java
 trunk/hudson/main/core/src/main/resources/lib/hudson/artifactList.jelly
 trunk/hudson/main/core/src/test/java/hudson/model/RunTest.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=14106
Log:
[FIXED JENKINS-2379] Fix artifact archiver and workspace browser to handle filenames
that need URL-encoding.

    Code changed in hudson
    User: : mindless
    Path:
    trunk/hudson/main/core/src/main/java/hudson/model/DirectoryBrowserSupport.java
    trunk/hudson/main/core/src/main/java/hudson/model/Run.java
    trunk/hudson/main/core/src/main/resources/lib/hudson/artifactList.jelly
    trunk/hudson/main/core/src/test/java/hudson/model/RunTest.java
    http://fisheye4.cenqua.com/changelog/hudson/?cs=14106
    Log:
    [FIXED JENKINS-2379] Fix artifact archiver and workspace browser to handle filenames
    that need URL-encoding.

  6. jenkins-infra-bot
    closed this as completedon Jan 2, 2009

  7. jenkins-infra-bot commented on Jan 10, 2009

    @jenkins-infra-bot
    jenkins-infra-bot
    on Jan 10, 2009
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in hudson
User: : mindless
Path:
 trunk/hudson/main/core/src/main/java/hudson/Util.java
 trunk/hudson/main/core/src/main/java/hudson/model/DirectoryBrowserSupport.java
 trunk/hudson/main/core/src/main/java/hudson/model/Run.java
 trunk/hudson/main/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly
 trunk/hudson/main/core/src/main/resources/hudson/model/Run/artifacts-index.jelly
 trunk/hudson/main/core/src/main/resources/lib/hudson/artifactList.jelly
 trunk/hudson/main/core/src/test/java/hudson/UtilTest.java
 trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=14355
Log:
[FIXED JENKINS-2793] Fix from JENKINS-2379 introduced a bug for artifact/workspace
filenames with spaces.
      

        
	
      • Added new Util.rawEncode which encodes the right set of characters (based on
  RFC1738) and deprecated Util.encode which only encodes non-ASCII.  Unit test too.
        • 
	
      • Change previous fix to use Util.rawEncode instead of URLEncoder.encode
        • 
	
      • New fix: add h.xmlEscape call for each displayed filename in artifacts/workspace
  so & and < are encoded for HTML display
        • 
	
      • Add all these fixes in Run/artifacts-index.jelly which wasn't included before
        •

    Code changed in hudson
    User: : mindless
    Path:
    trunk/hudson/main/core/src/main/java/hudson/Util.java
    trunk/hudson/main/core/src/main/java/hudson/model/DirectoryBrowserSupport.java
    trunk/hudson/main/core/src/main/java/hudson/model/Run.java
    trunk/hudson/main/core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly
    trunk/hudson/main/core/src/main/resources/hudson/model/Run/artifacts-index.jelly
    trunk/hudson/main/core/src/main/resources/lib/hudson/artifactList.jelly
    trunk/hudson/main/core/src/test/java/hudson/UtilTest.java
    trunk/www/changelog.html
    http://fisheye4.cenqua.com/changelog/hudson/?cs=14355
    Log:
    [FIXED JENKINS-2793] Fix from JENKINS-2379 introduced a bug for artifact/workspace
    filenames with spaces.

    • Added new Util.rawEncode which encodes the right set of characters (based on
      RFC1738) and deprecated Util.encode which only encodes non-ASCII. Unit test too.
    • Change previous fix to use Util.rawEncode instead of URLEncoder.encode
    • New fix: add h.xmlEscape call for each displayed filename in artifacts/workspace
      so & and < are encoded for HTML display
    • Add all these fixes in Run/artifacts-index.jelly which wasn't included before
  8. jenkins-infra-bot
    added
    bugFor changelog: Minor bug. Will be listed after features
    imported-jira-issue
    component:core
    priority:major
    resolution:fixed
    on Nov 24, 2025
  9. jenkins-infra-bot
    added the
    Bug
    issue type on Nov 25, 2025
  10. jenkins-infra-bot
    removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component:coreimported-jira-issuepriority:majorresolution:fixed

    Type

    Bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions