Repository navigation
[JENKINS-18776] @QueryParameter with @RelativePath broken #14742
Description
a stapler change in 1.208 broke the @InjectedParameter annotation handling.
When non-injected annotation (such as @RelativePath) annotation is present, it'll mask the handling of the injected annotation (such as @QueryParameter.)
Originally reported by 
kohsuke, imported from: @QueryParameter with @RelativePath broken
- assignee: kohsuke
- status: Resolved
- priority: Critical
- component(s): core
- label(s): 1.509.3-rejected, 1.509.4-fixed, regression
- resolution: Fixed
- resolved: 2013-07-16T19:35:32+00:00
- votes: 0
- watchers: 5
- imported: 2025-11-24
Raw content of original issue
a stapler change in 1.208 broke the @InjectedParameter annotation handling.
When non-injected annotation (such as @RelativePath) annotation is present, it'll mask the handling of the injected annotation (such as @QueryParameter.)
Activity
jenkins-infra-bot commentedon Jul 16, 2013
Raw content of original comment:
Should be easy enough to write a regression test for this, right?
jenkins-infra-bot commentedon Jul 16, 2013
Raw content of original comment:
Hmm, it looks like the SCM/issue link daemon has stopped working.
This fix is integrated toward 1.525.
jenkins-infra-bot commentedon Jul 30, 2013
Raw content of original comment:
I'm sorry but what needs to be backported to get this lts-candidate fixed?
jenkins-infra-bot commentedon Jul 30, 2013
Raw content of original comment:
I just looked in jenkins-1.524...jenkins-1.525 to try to figure out where the purported fix was, but there are no changes here except version number! Did the release process go haywire?
jenkins-infra-bot commentedon Jul 30, 2013
Raw content of original comment:
Anyway jenkinsci/stapler@fb1fa99 is the fix, in Stapler 1.214. That was integrated in fc836c1 and apparently required several follow-up test fixes in efc0ca1...504dadc (I am guessing). Seems this is really in 1.526, since 1.525 was just botched.
jenkins-infra-bot commentedon Aug 1, 2013
Raw content of original comment:
Thanks Jesse. It seems to require bbaeade as well for tests to succeed.
jenkins-infra-bot commentedon Aug 13, 2013
Raw content of original comment:
Code changed in jenkins
User: Oliver Gondža
Path:
changelog.html
core/pom.xml
core/src/test/groovy/hudson/util/SecretRewriterTest.groovy
core/src/test/groovy/hudson/util/SecretTest.groovy
core/src/test/groovy/jenkins/security/CryptoConfidentialKeyTest.groovy
core/src/test/groovy/jenkins/security/DefaultConfidentialStoreTest.groovy
core/src/test/groovy/jenkins/security/HMACConfidentialKeyTest.groovy
core/src/test/groovy/jenkins/security/HexStringConfidentialKeyTest.groovy
core/src/test/java/hudson/util/SecretRewriterTest.groovy
core/src/test/java/hudson/util/SecretTest.groovy
core/src/test/java/jenkins/security/CryptoConfidentialKeyTest.groovy
core/src/test/java/jenkins/security/DefaultConfidentialStoreTest.groovy
core/src/test/java/jenkins/security/HMACConfidentialKeyTest.groovy
core/src/test/java/jenkins/security/HexStringConfidentialKeyTest.groovy
pom.xml
test/pom.xml
test/src/test/groovy/hudson/RelativePathTest.groovy
test/src/test/resources/hudson/RelativePathTest/Model/config.groovy
test/src/test/resources/hudson/RelativePathTest/index.groovy
http://jenkins-ci.org/commit/jenkins/c9eb236d7a09c3a638e2ee4f84879da76c75abab
Log:
Revert backport of
JENKINS-18776(sometimes incorrectly refered to as JENKINS-18771)This reverts commit f43b3cd.
This reverts commit 72cea1a.
This reverts commit 01445f4.
This reverts commit ce08bdf.
This reverts commit 448e580.
This reverts commit 381ab03.
jenkins-infra-bot commentedon Sep 19, 2013
Raw content of original comment:
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
test/src/main/java/org/jvnet/hudson/test/TestExtensionLoader.java
http://jenkins-ci.org/commit/jenkins/fb31f6d8dc77cc9d27d7451e13f8c8d328ecb538
Log:
JENKINS-18776Groovy compiler doesn't seem to put the enclosing class information in the class file.(cherry picked from commit eec271d)
jenkins-infra-bot commentedon Sep 19, 2013
Raw content of original comment:
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
test/pom.xml
http://jenkins-ci.org/commit/jenkins/3d30b3a44134c8ff3d0a7005541c6fa1faa68a18
Log:
JENKINS-18776Fixing a test failure in RelativePathTestIt turns out that Groovy compiler we use to compile src/test/groovy was
not properly generating the 'enclosing class' information inside
*.class, which was causing the load failure of the descriptors marked
by @TestExtension in test code.
To fix this and forestall other possible GMaven related issues, I
decided to bump up the GMaven version. As it turns out, Codehaus GMaven
had ceased the development of the 1.x branch, so I initially tried 2.x
release line.
The 2.x release line got rid of the stub generation functionality, which
we badly need for annotation processing. It instead recommend using
Eclipse compiler to jointly compile Java and Groovy source code
together, but when I tried to compile our tests, it failed to properly
handle nested classes. The compiler quality appears quite premature.
I was then going back to GMaven 1.5, the last 1.x release. I took this
opportunity to rebase my local patches in org.kohsuke.gmaven to the
latest release, which in my mind gets justified now that the upstream
has ceased the development.
My local patch to GMaven is captured in GMAVEN-3 and GMAVEN-4
(see http://jira.codehaus.org/browse/GMAVEN-3 and
http://jira.codehaus.org/browse/GMAVEN-4).
GMAVEN-4 is claimed to be fixed, but when I tried to compile our source
tree I discovered that its handling of nested types breaks the generated
stub code.
In the end, I managed to patch gmaven and posted 1.5-jenkins-1.
The bottom line is, we can now use @TestExtension correctly with Groovy
tests. Also on the upside, we can get rid of org.kohsuke.gmaven and
avoid the current confusion situation of using two GMaven plugins.
I'll make a follow-up change to remove org.kohsuke.gmaven from elsewhere
in our POM.
(cherry picked from commit bd256ac)
Conflicts:
test/pom.xml
jenkins-infra-bot commentedon Sep 19, 2013
Raw content of original comment:
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
test/src/main/java/org/jvnet/hudson/test/TestExtensionLoader.java
http://jenkins-ci.org/commit/jenkins/3559a52e2dc751bcd9fc3b335c17efc9c1b54f2b
Log:
JENKINS-18776This work around no longer necessary,... as the newer Groovy compiler produces the proper enclosing class
infromation.
(cherry picked from commit 92c2503)
jenkins-infra-bot commentedon Sep 19, 2013
Raw content of original comment:
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
core/pom.xml
core/src/test/groovy/hudson/util/SecretRewriterTest.groovy
core/src/test/groovy/hudson/util/SecretTest.groovy
core/src/test/groovy/jenkins/security/CryptoConfidentialKeyTest.groovy
core/src/test/groovy/jenkins/security/DefaultConfidentialStoreTest.groovy
core/src/test/groovy/jenkins/security/HMACConfidentialKeyTest.groovy
core/src/test/groovy/jenkins/security/HexStringConfidentialKeyTest.groovy
core/src/test/java/hudson/util/SecretRewriterTest.groovy
core/src/test/java/hudson/util/SecretTest.groovy
core/src/test/java/jenkins/security/CryptoConfidentialKeyTest.groovy
core/src/test/java/jenkins/security/DefaultConfidentialStoreTest.groovy
core/src/test/java/jenkins/security/HMACConfidentialKeyTest.groovy
core/src/test/java/jenkins/security/HexStringConfidentialKeyTest.groovy
pom.xml
test/pom.xml
http://jenkins-ci.org/commit/jenkins/998dc0d27cca1ed3183508cd807fc35d76d119bc
Log:
JENKINS-18776Replacing org.kohsuke.gmaven by org.codehaus.gmaven(cherry picked from commit bf80986)
Conflicts:
core/pom.xml
jenkins-infra-bot commentedon Sep 19, 2013
Raw content of original comment:
Code changed in jenkins
User: Oliver Gondža
Path:
test/pom.xml
test/src/test/groovy/hudson/RelativePathTest.groovy
test/src/test/resources/hudson/RelativePathTest/Model/config.groovy
test/src/test/resources/hudson/RelativePathTest/index.groovy
http://jenkins-ci.org/commit/jenkins/9335c4446faf73a7c58d8189874e1dd2fccf5b5e
Log:
[FIXED JENKINS-18776]
This reverts commit c9eb236.